Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict behat/mink-selenium2-driver:>=1.7.0 #945

Merged

Conversation

Rafikooo
Copy link
Contributor

@Rafikooo Rafikooo commented Feb 7, 2024

This version adds strict type to the Behat\Mink\Driver\Selenium2Driver::visit($url) method which causes a fatal error because the method signature is no longer compatible with the parent

@Rafikooo Rafikooo requested a review from a team as a code owner February 7, 2024 17:07
@NoResponseMate NoResponseMate merged commit cdaa9a1 into Sylius:1.12 Feb 12, 2024
8 checks passed
@NoResponseMate
Copy link
Contributor

Thank you, @Rafikooo!

GSadee added a commit to Sylius/PayPalPlugin that referenced this pull request Feb 15, 2024
…on of `symfony/flex` to `^2.4` (Rafikooo)

This PR was merged into the 1.5 branch.

Discussion
----------

| Q               | A
| --------------- | -----
| Branch?         | 1.5
| Bug fix?        | yes
| New feature?    | no
| Related tickets | Sylius/Sylius-Standard#945

Both changes were interdependent, so I propose to combine them into one PR to achieve the green build

Commits
-------

7347d95 [Conflict] Add conflict with behat/mink-selenium2-driver:>=1.7.0
bea2505 [CI] Bump version of symfony/flex to ^2.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants