-
Notifications
You must be signed in to change notification settings - Fork 58
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
bug #285 Conflict
behat/mink-selenium2-driver:>=1.7.0
&& Bump versi…
…on of `symfony/flex` to `^2.4` (Rafikooo) This PR was merged into the 1.5 branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | 1.5 | Bug fix? | yes | New feature? | no | Related tickets | Sylius/Sylius-Standard#945 Both changes were interdependent, so I propose to combine them into one PR to achieve the green build Commits ------- 7347d95 [Conflict] Add conflict with behat/mink-selenium2-driver:>=1.7.0 bea2505 [CI] Bump version of symfony/flex to ^2.4
- Loading branch information
Showing
3 changed files
with
14 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
# CONFLICTS | ||
|
||
This document explains why certain conflicts were added to `composer.json` and | ||
references related issues. | ||
|
||
- `behat/mink-selenium2-driver:>=1.7.0`: | ||
|
||
This version adds strict type to the `Behat\Mink\Driver\Selenium2Driver::visit($url)` method | ||
which causes a fatal error because the method signature is no longer compatible with the parent class: | ||
`PHP Fatal error: Declaration of Behat\Mink\Driver\Selenium2Driver::visit(string $url) must be compatible with Behat\Mink\Driver\CoreDriver::visit($url) in /home/runner/work/Sylius-Standard/Sylius-Standard/vendor/behat/mink-selenium2-driver/src/Selenium2Driver.php on line 401` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters