Skip to content

Commit

Permalink
minor #945 Conflict behat/mink-selenium2-driver:>=1.7.0 (Rafikooo)
Browse files Browse the repository at this point in the history
This PR was merged into the 1.12 branch.

Discussion
----------

This version adds strict type to the `Behat\Mink\Driver\Selenium2Driver::visit($url)` method which causes a fatal error because the method signature is no longer compatible with the parent 

Commits
-------
  [Conflict] Add conflict with behat/mink-selenium2-driver:>=1.7.0
  • Loading branch information
NoResponseMate authored Feb 12, 2024
2 parents bf7284b + 595da9c commit cdaa9a1
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 3 deletions.
10 changes: 8 additions & 2 deletions CONFLICTS.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,11 @@ references related issues.

- `symfony/framework-bundle:6.2.8`:

This version is missing the service alias `validator.expression`
which causes ValidatorException exception to be thrown when using `Expression` constraint.
This version is missing the service alias `validator.expression`
which causes ValidatorException exception to be thrown when using `Expression` constraint.

- `behat/mink-selenium2-driver:>=1.7.0`:

This version adds strict type to the `Behat\Mink\Driver\Selenium2Driver::visit($url)` method
which causes a fatal error because the method signature is no longer compatible with the parent class:
`PHP Fatal error: Declaration of Behat\Mink\Driver\Selenium2Driver::visit(string $url) must be compatible with Behat\Mink\Driver\CoreDriver::visit($url) in /home/runner/work/Sylius-Standard/Sylius-Standard/vendor/behat/mink-selenium2-driver/src/Selenium2Driver.php on line 401`
3 changes: 2 additions & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,8 @@
"symfony/web-profiler-bundle": "^5.4 || ^6.0"
},
"conflict": {
"symfony/framework-bundle": "6.2.8"
"symfony/framework-bundle": "6.2.8",
"behat/mink-selenium2-driver": ">=1.7.0"
},
"config": {
"preferred-install": {
Expand Down

0 comments on commit cdaa9a1

Please sign in to comment.