Detect rails as the testing framework if bin/rails exists

[Earlopain]

Motivation

I have an application that depends on Rails in the following way:

# Gemfile
rails_version = "~> 7.1.0"
gem "actionpack",    rails_version
gem "actionview",    rails_version
gem "activemodel",   rails_version
gem "activerecord",  rails_version
gem "activesupport", rails_version
gem "railties",      rails_version

The intent is to not pull in the other framework parts, like activestorage for example. Since the testing framework detection currently does a check for rails I am not getting code lenses for tests with ruby-lsp-rails.

See Shopify/ruby-lsp-rails#47 for similar reasoning.

Implementation

Also check for railties. A rails app doesn't boot if railties isn't present (require "rails/commands" in bin/rails is the first failure point).

Automated Tests

Yup.

Manual Tests

Create a rails app with the above gemfile, create a test, observe code lense.

[andyw8]

Thanks for the PR. I have a slight concern that there could be some gems that depend on railties but use plain minitest. 🤔

[Earlopain]

Hm, right. What about also checking for bin/rails instead?

Something like

File.exist?(File.join(workspace_path, "bin/rails"))

[andyw8]

Yeah, that would have less chance of a false positive. Any thoughts @st0012, @vinistock ?

[st0012]

I changed the label to bugfix because IMO we should have used bin/rails instead. Thanks for the PR 🙏

[Earlopain]

Seems somewhat relevant to #1466, #1467. While not the same I find it close enough to at least link to.

[vinistock]

Suggested change

	elsif File.exist?(File.join(workspace_path, "bin/rails"))
	elsif File.exist?(File.join(workspace_path, "bin", "rails"))

[st0012]

Ah sorry I clicked merge at the same time 😅

[vinistock]

Let's apply this change. We can't use forward slashes for Windows.

[Earlopain]

Hm, is that really the fix then? https://ruby-doc.org/3.3.0/File.html#method-c-join doesn't mention this being platform-aware and seems to always use / anyways.

[vinistock]

Then maybe we should be using Pathname instead and need to switch this to

Suggested change

	elsif File.exist?(File.join(workspace_path, "bin/rails"))
	elsif Pathname.new(workspace_path).join("bin").join("rails").exist?

[vinistock]

Actually, maybe Ruby already takes care of that under the hood https://github.com/ruby/ruby/blob/b09604e1fd5768daf31aaa4f8130fa8cd9b8d240/file.c#L252.

[Earlopain]

I think this is fine, yeah. I wanted to properly check in my VM but I don't think I'm going through the bother of properly setting ruby up, so a boring irb session will have to do:

[vinistock]

This PR will close #1466, so let's add to the description.

[Earlopain]

I don't think it will close this? There are still a few other places that check against a rails dependecy here.

[vinistock]

Do you mean in the custom bundle logic? If so, yeah that's true.