Update tests for ruby-lsp changes
#350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Shopify/ruby-lsp#1896 the testing framework for rails is dependant on the presence on `bin/rails`
|
Note: There are some green checks even though I'm pretty sure they should fail. I think tests doesn't run on windows right now because of how it is invoked in the workflow. It probably chokes on the https://github.com/Shopify/ruby-lsp-rails/actions/runs/8821159752 |
andyw8
approved these changes
Apr 24, 2024
Thanks, logged as #351 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Shopify/ruby-lsp#1896 the testing framework for rails is dependant on the presence on
bin/rails.For #341 I need to bump the minimum required
ruby-lspbut tests are failing due to the above PR, so I fix them here in a separate PR.