Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve how we detect Rails apps #1466

Closed
andyw8 opened this issue Mar 6, 2024 · 2 comments
Closed

Improve how we detect Rails apps #1466

andyw8 opened this issue Mar 6, 2024 · 2 comments
Labels
bug Something isn't working server This pull request should be included in the server gem's release notes Stale

Comments

@andyw8
Copy link
Contributor

andyw8 commented Mar 6, 2024

Description

Currently we look for a dependency on the Rails gem, and if found, we assume a Rails app is present, and add "ruby-lsp-rails" to the custom bundle. But this approach can result in false positives. Instead, we should check the presence of bin/rails.

@andyw8 andyw8 added bug Something isn't working server This pull request should be included in the server gem's release notes labels Mar 6, 2024
Copy link
Contributor

github-actions bot commented May 6, 2024

This issue is being marked as stale because there was no activity in the last 2 months

@github-actions github-actions bot added the Stale label May 6, 2024
@andyw8
Copy link
Contributor Author

andyw8 commented May 6, 2024

Done in #1896

@andyw8 andyw8 closed this as completed May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working server This pull request should be included in the server gem's release notes Stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant