Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing #36 & #38 #37

Merged
merged 3 commits into from
Oct 12, 2023
Merged

fixing #36 & #38 #37

merged 3 commits into from
Oct 12, 2023

Conversation

bandophahita
Copy link
Contributor

@bandophahita bandophahita commented Sep 22, 2023 •
edited
Loading

Fixes #36 and #38

@bandophahita bandophahita changed the title fixing https://github.com/ScreenPyHQ/screenpy_selenium/issues/36 fixing #36 Sep 22, 2023
@bandophahita
Copy link
Contributor Author

bandophahita commented Sep 22, 2023 •
edited
Loading

There appear to be other tests failing at the moment that have nothing to do with the metadata. I'll address those in separate PR.

*for posterity: the failing tests are due to a mismatch in how Protocol works in native vs typing_extensions.

@bandophahita bandophahita requested a review from perrygoy October 12, 2023 12:48
@bandophahita bandophahita changed the title fixing #36 fixing #36 & #38 Oct 12, 2023
perrygoy
perrygoy approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@perrygoy perrygoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a long and complicated road for such a small fix. Thanks for putting in the legwork on this one, i wish that error were a little more direct.

@bandophahita bandophahita merged commit d5cac93 into ScreenPyHQ:trunk Oct 12, 2023
9 checks passed
@bandophahita bandophahita deleted the fixing_metadata branch January 10, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perrygoy perrygoy perrygoy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

metadata test fails
2 participants
@bandophahita @perrygoy