fixing #36 & #38 (#37)

* fixing #36 * fixing #38 - runtime protocol checks * removing test protocol that isn't used and causes issues with isinstance against ErrorKeeper
ScreenPyHQ · Oct 12, 2023 · d5cac93 · d5cac93
1 parent a912b21
commit d5cac93
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 14 deletions.
diff --git a/poetry.lock b/poetry.lock
diff --git a/tests/test__version__.py b/tests/test__version__.py
@@ -2,6 +2,6 @@
 
 
 def test_metadata() -> None:
-    assert __version__.__title__ == "screenpy-selenium"
+    assert __version__.__title__ == "screenpy_selenium"
     assert __version__.__license__ == "MIT"
     assert __version__.__author__ == "Perry Goy"
diff --git a/tests/unittest_protocols.py b/tests/unittest_protocols.py
@@ -1,30 +1,25 @@
-from typing import Protocol
+from typing import Protocol, runtime_checkable
 
-from screenpy import Answerable, ErrorKeeper, Forgettable, Performable
+from screenpy import Answerable, Describable, Forgettable, Performable
 
 from screenpy_selenium import Chainable
 
 
-class Describable(Protocol):
-    def describe(self) -> str:
-        ...
-
-
+@runtime_checkable
 class Question(Answerable, Describable, Protocol):
     ...
 
 
-class ErrorQuestion(Answerable, Describable, ErrorKeeper, Protocol):
-    ...
-
-
+@runtime_checkable
 class Action(Performable, Describable, Protocol):
     ...
 
 
+@runtime_checkable
 class ChainableAction(Chainable, Performable, Describable, Protocol):
     ...
 
 
+@runtime_checkable
 class Ability(Forgettable, Protocol):
     ...