Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing #36 & #38 #37

Merged
merged 3 commits into from
Oct 12, 2023
Merged

fixing #36 & #38 #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6b3062f
fixing https://github.com/ScreenPyHQ/screenpy_selenium/issues/36
bandophahita Sep 22, 2023
507227e
fixing #38 - runtime protocol checks
bandophahita Oct 12, 2023
3adacdc
removing test protocol that isn't used and causes issues with isinsta…
bandophahita Oct 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions poetry.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion tests/test__version__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@


def test_metadata() -> None:
assert __version__.__title__ == "screenpy-selenium"
assert __version__.__title__ == "screenpy_selenium"
assert __version__.__license__ == "MIT"
assert __version__.__author__ == "Perry Goy"
17 changes: 6 additions & 11 deletions tests/unittest_protocols.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,30 +1,25 @@
from typing import Protocol
from typing import Protocol, runtime_checkable

from screenpy import Answerable, ErrorKeeper, Forgettable, Performable
from screenpy import Answerable, Describable, Forgettable, Performable

from screenpy_selenium import Chainable


class Describable(Protocol):
def describe(self) -> str:
...


@runtime_checkable
class Question(Answerable, Describable, Protocol):
...


class ErrorQuestion(Answerable, Describable, ErrorKeeper, Protocol):
...


@runtime_checkable
class Action(Performable, Describable, Protocol):
...


@runtime_checkable
class ChainableAction(Chainable, Performable, Describable, Protocol):
...


@runtime_checkable
class Ability(Forgettable, Protocol):
...