Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D8CORE-7558: added the global footer in dark with no logo #820

Merged
merged 6 commits into from
Nov 1, 2024

Conversation

jenbreese
Copy link
Contributor

@jenbreese jenbreese commented Oct 14, 2024

READY FOR REVIEW

Summary

  • Adding a global footer to the Minimally Branded subtheme
  • Removed the footer logo
  • Used dark grey with white text.
  • Used the Decanter global footer so it gets any changes.

Review By (Date)

  • When time allows

Criticality

  • Normal

Urgency

  • Normal

Review Tasks

Setup tasks and/or behavior to test

  1. Open branch with GitPod
  2. Navigate to Appearances and set the Minimally Branded subtheme as default.
  3. Verify the footer exists.
  4. Verify it looks good.
  5. Verify it on the different breakpoints.

Site Configuration Sync

  • Is there a config:export in this PR that changes the config sync directory?

Front End Validation

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided? eg (unit, behat, or codeception)

Code security

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve?
  • Is the approach to the problem appropriate?

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

- D8CORE-7558

Resources

@jenbreese
Copy link
Contributor Author

Hi @pookmish The tests are ok now, excluding the Drupal 11 ones. Will you let me know what you think? Thank you!

@pookmish pookmish force-pushed the D8CORE-7558--global-footer branch from 552ea08 to 41a43bb Compare November 1, 2024 21:02
@pookmish pookmish merged commit 7939306 into 11.x Nov 1, 2024
5 of 8 checks passed
@pookmish pookmish deleted the D8CORE-7558--global-footer branch November 1, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants