Skip to content

Commit

Permalink
D8CORE-7558: added the global footer to minimal theme in dark with no…
Browse files Browse the repository at this point in the history
… logo (#820)
  • Loading branch information
jenbreese authored Nov 1, 2024
1 parent e1d68a3 commit 7939306
Show file tree
Hide file tree
Showing 6 changed files with 34 additions and 2 deletions.
2 changes: 1 addition & 1 deletion tests/codeception/acceptance/SubThemeCest.php
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ public function testMinimalSubtheme(AcceptanceTester $I) {
$I->canSeeResponseCodeIs(200);
$I->seeInSource('<span class="su-lockup__wordmark"></span>');
$I->dontSeeElement('.su-brand-bar__logo');
$I->dontSeeElement('.su-global-footer__container');
$I->seeElement('.su-global-footer__container');
$I->dontSeeElement('.su-brand-bar--default');
}

Expand Down

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
@charset "UTF-8";

.su-global-footer {
background-color: $su-color-black;

.su-global-footer__brand {
display: none;
}

@include grid-media-min('xs') {
.su-global-footer__content {
padding-left: 0;
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
@charset "UTF-8";

//
// 5. Theme
//

// Purely visual styling (“look-and-feel”) for a component.
//
// Purely visual styling, such as border, box-shadow, colors and backgrounds,
// font properties, etc. Ideally, these should be separated enough from a
// component’s structure to be “swappable”, and omitting these entirely should
// not break the component’s functionality or basic usability.

// Config and supporting scss.
@import 'global-footer';
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@

// Components.
@import 'brandbar/index.scss';
@import 'global-footer/index.scss';
@import 'lockup/index.scss';
@import 'masthead/index.scss';
@import 'main-nav/index.scss';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,5 @@
{%- endif %}

<div class="su-global-footer su-global-footer--dark">
{%- include template_global_footer with { modifier_class : global_footer_variant } -%}
</div> <!-- su-global-footer end -->

0 comments on commit 7939306

Please sign in to comment.