Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D8CORE-7558: added the global footer in dark with no logo #820

Merged
merged 6 commits into from
Nov 1, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/codeception/acceptance/SubThemeCest.php
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ public function testMinimalSubtheme(AcceptanceTester $I) {
$I->canSeeResponseCodeIs(200);
$I->seeInSource('<span class="su-lockup__wordmark"></span>');
$I->dontSeeElement('.su-brand-bar__logo');
$I->dontSeeElement('.su-global-footer__container');
$I->seeElement('.su-global-footer__container');
$I->dontSeeElement('.su-brand-bar--default');
}

Expand Down

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
@charset "UTF-8";

.su-global-footer {
background-color: $su-color-black;

.su-global-footer__brand {
display: none;
}

@include grid-media-min('xs') {
.su-global-footer__content {
padding-left: 0;
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
@charset "UTF-8";

//
// 5. Theme
//

// Purely visual styling (“look-and-feel”) for a component.
//
// Purely visual styling, such as border, box-shadow, colors and backgrounds,
// font properties, etc. Ideally, these should be separated enough from a
// component’s structure to be “swappable”, and omitting these entirely should
// not break the component’s functionality or basic usability.

// Config and supporting scss.
@import 'global-footer';
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@

// Components.
@import 'brandbar/index.scss';
@import 'global-footer/index.scss';
@import 'lockup/index.scss';
@import 'masthead/index.scss';
@import 'main-nav/index.scss';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,5 @@
{%- endif %}

<div class="su-global-footer su-global-footer--dark">
{%- include template_global_footer with { modifier_class : global_footer_variant } -%}
</div> <!-- su-global-footer end -->
Loading