Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix removing previous module files in PHPStan tests #594

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Fix removing previous module files in PHPStan tests #594

merged 1 commit into from
Sep 26, 2023

Conversation

kpodemski
Copy link
Contributor

@kpodemski kpodemski commented Sep 1, 2023 •
edited
Loading

Questions Answers
Description? The previous way of removing the directory didn't work correctly.
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket? Much less frustration thanks to it 😂
How to test? CI is 🟢

@kpodemski kpodemski changed the title [wipImproved PHPStan script [wip] Improved PHPStan script Sep 1, 2023
@kpodemski kpodemski closed this Sep 1, 2023
@kpodemski kpodemski reopened this Sep 1, 2023
@kpodemski kpodemski closed this Sep 1, 2023
@kpodemski kpodemski reopened this Sep 1, 2023
@kpodemski kpodemski closed this Sep 1, 2023
@kpodemski kpodemski reopened this Sep 1, 2023
@kpodemski kpodemski force-pushed the improved-phpstan-script branch from 1de17b2 to b3278e0 Compare September 1, 2023 21:20
@kpodemski kpodemski changed the title [wip] Improved PHPStan script Fix removing previous module directory in PHPStan tests Sep 1, 2023
@kpodemski kpodemski closed this Sep 1, 2023
@kpodemski kpodemski reopened this Sep 1, 2023
@kpodemski kpodemski closed this Sep 1, 2023
@kpodemski kpodemski reopened this Sep 1, 2023
@kpodemski
Fix removing previous module directory in PHPStan tests
cc34098 
test

test2

test3

Fix removing previous directory with a module

Test

test2
@kpodemski kpodemski force-pushed the improved-phpstan-script branch from d135507 to cc34098 Compare September 1, 2023 21:43
@kpodemski kpodemski changed the title Fix removing previous module directory in PHPStan tests Fix removing previous module files in PHPStan tests Sep 1, 2023
This was referenced Sep 11, 2023
Merged
Merged
@matks
Copy link
Contributor

matks commented Sep 12, 2023

Hi @kpodemski what does this mean

DO NOT MERGE BEFORE RELEASE

When should we merge this?

@matks
Copy link
Contributor

matks commented Sep 13, 2023

Thanks to @leemyongpakvn I understood that "DO NOT MERGE BEFORE RELEASE" actually meant "we dont want to reset the merge PR once again 😭"

@kpodemski
Copy link
Contributor Author

kpodemski commented Sep 25, 2023 •
edited
Loading

We can merge this. I'll get back to the blockreassurance release afterward.

leemyongpakvn
leemyongpakvn approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@leemyongpakvn leemyongpakvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go

@ps-jarvis ps-jarvis added the waiting for QA Status: Waiting for QA feedback label Sep 26, 2023
@leemyongpakvn leemyongpakvn added this to the 5.1.3 milestone Sep 26, 2023
@kpodemski kpodemski merged commit ee3434c into PrestaShop:dev Sep 26, 2023
15 checks passed
This was referenced Sep 28, 2023
Merged
Merged
@leemyongpakvn leemyongpakvn removed the waiting for QA Status: Waiting for QA feedback label Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leemyongpakvn leemyongpakvn leemyongpakvn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
PR Dashboard
Archived in project
Milestone
5.1.3
Development

Successfully merging this pull request may close these issues.
4 participants
@kpodemski @matks @leemyongpakvn @ps-jarvis