Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix removing previous module files in PHPStan tests #36

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Fix removing previous module files in PHPStan tests #36

merged 1 commit into from
Sep 20, 2023

Conversation

leemyongpakvn
Copy link
Contributor

@leemyongpakvn leemyongpakvn commented Sep 11, 2023 •
edited
Loading

Questions Answers
Description? The previous way of removing the directory didn't work correctly.
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket? This is just a copy of PrestaShop/blockreassurance#594
How to test? CI is 🟢 (with less random php-test rm -rf failures :)

matks
matks reviewed Sep 12, 2023
View reviewed changes
Copy link
Contributor

@matks matks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leemyongpakvn The PR PrestaShop/blockreassurance#594 is marked

DO NOT MERGE BEFORE RELEASE

Should we do the same for this PR?

@leemyongpakvn
Copy link
Contributor Author

leemyongpakvn commented Sep 13, 2023 •
edited
Loading

@matks No, we should not, because there is no awaiting Release PR in this repo.
kpodemski wrote that note because we have a 3-month-awaiting-Release PR there.:)

@matks
Copy link
Contributor

matks commented Sep 13, 2023

Haaa so the "DO NOT MERGE BEFORE RELEASE" actually meant "we dont want to reset the merge PR once again 😭"

@aniszr aniszr self-assigned this Sep 20, 2023
aniszr
aniszr approved these changes Sep 20, 2023
View reviewed changes
Copy link

@aniszr aniszr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @leemyongpakvn

Thanks for your PR!

CI 🟢

image

QA ✔️

Thanks!

@nicosomb nicosomb added this to the 3.0.0 milestone Sep 20, 2023
@nicosomb nicosomb merged commit f4a9f28 into PrestaShop:dev Sep 20, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matks matks matks left review comments

@aniszr aniszr aniszr approved these changes

@tleon tleon tleon approved these changes

Assignees

@aniszr aniszr

Labels
QA ✔️
Projects
PR Dashboard
Archived in project
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
6 participants
@leemyongpakvn @matks @tleon @aniszr @nicosomb @ps-jarvis