Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix removing previous module files in PHPStan tests #929

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Fix removing previous module files in PHPStan tests #929

merged 1 commit into from
Sep 29, 2023

Conversation

leemyongpakvn
Copy link
Contributor

@leemyongpakvn leemyongpakvn commented Sep 28, 2023 •
edited by eternoendless
Loading

Questions Answers
Description? The previous way of removing the directory didn't work correctly.
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket? This is just a copy of PrestaShop/blockreassurance#594
How to test? CI is 🟢 (with less random php-test rm -rf failures)

This change is Reviewable

@kpodemski kpodemski added this to the 3.14.0 milestone Sep 29, 2023
@kpodemski kpodemski merged commit 0601442 into PrestaShop:dev Sep 29, 2023
11 checks passed
@kpodemski
Copy link
Contributor

thanks @leemyongpakvn :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpodemski kpodemski kpodemski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
PR Dashboard
Archived in project
Milestone
3.14.0
Development

Successfully merging this pull request may close these issues.
2 participants
@leemyongpakvn @kpodemski