Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/ovos-gui+ovos-messagebus packages #292

Merged
merged 3 commits into from
Apr 29, 2023
Merged

Conversation

JarbasAl
Copy link
Member

@JarbasAl JarbasAl commented Mar 3, 2023

updates misc imports to use utils and workshop

@JarbasAl JarbasAl added refactor code refactor without functional changes packaging dependency updates or packaging changes labels Mar 3, 2023
@JarbasAl JarbasAl requested a review from NeonDaniel March 3, 2023 21:17
@JarbasAl JarbasAl mentioned this pull request Mar 3, 2023
@JarbasAl JarbasAl added this to the 0.0.8 milestone Mar 13, 2023
@JarbasAl JarbasAl force-pushed the refactor/split_services branch from ece7b70 to 36ba275 Compare April 4, 2023 19:37
@JarbasAl JarbasAl marked this pull request as ready for review April 4, 2023 21:19
@JarbasAl JarbasAl force-pushed the refactor/split_services branch from 48e43ef to fce3999 Compare April 4, 2023 22:00
@JarbasAl JarbasAl mentioned this pull request Apr 5, 2023
@JarbasAl JarbasAl force-pushed the refactor/split_services branch from 286dcee to 6fa3310 Compare April 5, 2023 20:05
This was referenced Apr 15, 2023
@JarbasAl JarbasAl force-pushed the refactor/split_services branch from 4f61077 to f0f8433 Compare April 29, 2023 21:34
@codecov
Copy link

codecov bot commented Apr 29, 2023

Codecov Report

Merging #292 (f5cc6a7) into dev (6ceb058) will decrease coverage by 32.21%.
The diff coverage is 7.30%.

@@             Coverage Diff             @@
##              dev     #292       +/-   ##
===========================================
- Coverage   50.35%   18.14%   -32.21%     
===========================================
  Files         119      153       +34     
  Lines       10077     4678     -5399     
===========================================
- Hits         5074      849     -4225     
+ Misses       5003     3829     -1174     
Impacted Files Coverage Δ
mycroft/api/__init__.py 0.00% <0.00%> (-78.23%) ⬇️
mycroft/audio/__main__.py 0.00% <0.00%> (ø)
mycroft/audio/service.py 0.00% <0.00%> (ø)
mycroft/audio/services/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
mycroft/audio/services/simple/__init__.py 0.00% <0.00%> (-85.99%) ⬇️
mycroft/audio/services/vlc/__init__.py 0.00% <0.00%> (ø)
mycroft/audio/speech.py 0.00% <0.00%> (-44.58%) ⬇️
mycroft/audio/tts.py 0.00% <0.00%> (ø)
mycroft/audio/utils.py 0.00% <0.00%> (-92.86%) ⬇️
mycroft/client/enclosure/__init__.py 0.00% <0.00%> (ø)
... and 124 more

... and 11 files with indirect coverage changes

@JarbasAl JarbasAl changed the title Refactor/split services Refactor/ovos-gui+ovos-messagebus packages Apr 29, 2023
no import *

move tests to ovos-gui

move tests to ovos-gui

default mycroft.conf moved to ovos-config package

migrate ovos-bus

migrate ovos-gui
@JarbasAl JarbasAl force-pushed the refactor/split_services branch from 4f34d34 to a62debe Compare April 29, 2023 21:53
@JarbasAl JarbasAl merged commit c9f1d05 into dev Apr 29, 2023
@JarbasAl JarbasAl deleted the refactor/split_services branch April 29, 2023 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packaging dependency updates or packaging changes refactor code refactor without functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant