Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/converse_session #160

Merged
merged 4 commits into from
Sep 30, 2023
Merged

Conversation

NeonJarbas
Copy link

@NeonJarbas NeonJarbas commented Jun 15, 2022

adds the concept of Session to converse pipeline, refactors converse and get_response to be event based and per session, requires OpenVoiceOS/OVOS-workshop#68

see session implementation here https://github.com/OpenVoiceOS/ovos-bus-client/blob/dev/ovos_bus_client/session.py

a session can be a user, a client device, or anything else providing utterances to core. immediate applications are in neon multi user setup (each klat user has a session) and in hivemind (each client has a session)

@JarbasAl JarbasAl added the enhancement New feature or request label Jun 15, 2022
@JarbasAl JarbasAl requested a review from NeonDaniel June 15, 2022 14:18
@JarbasAl JarbasAl marked this pull request as ready for review June 17, 2022 14:03
@JarbasAl JarbasAl marked this pull request as draft August 20, 2022 00:26
@JarbasAl JarbasAl force-pushed the feat/converse_session branch from 7f29c2e to ccfb6ee Compare November 11, 2022 16:19
@NeonDaniel
Copy link
Member

Would it make sense to have context like:

context:
  session:
    id:

This lets the client include any other session data like timestamps, active/inactive, voice vs text, and anything else the client might care about

@JarbasAl JarbasAl mentioned this pull request Nov 24, 2022
Copy link
Member

@NeonDaniel NeonDaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bus client refactor could probably be a PR on its own to get it in immediately for testing

@JarbasAl
Copy link
Member

The bus client refactor could probably be a PR on its own to get it in immediately for testing

the session utils are a little different, this also replaces the mycroft.session module so it made sense to do it all together.

splitting PRs could be a problem, we will be getting a session object that is not actually managed, the calls to the new util get lang_from_message will also account for this new session object. I don't immediately see an issue there, but i feel this should all be tested together. this PR will need a lot more unittests too

@JarbasAl JarbasAl added this to the 0.0.7 milestone Jan 26, 2023
@JarbasAl JarbasAl closed this Apr 5, 2023
@JarbasAl
Copy link
Member

JarbasAl commented Apr 5, 2023

actually leave this open and I will rebase on top of #292

@JarbasAl JarbasAl reopened this Apr 5, 2023
@JarbasAl JarbasAl force-pushed the feat/converse_session branch from f8cd161 to b423c9c Compare April 11, 2023 19:45
@JarbasAl JarbasAl requested a review from NeonDaniel April 11, 2023 19:48
@JarbasAl JarbasAl marked this pull request as ready for review April 11, 2023 19:48
JarbasAl added a commit to OpenVoiceOS/OVOS-workshop that referenced this pull request Apr 20, 2023
make get_response event based

companion PR to OpenVoiceOS/ovos-core#160
This was referenced Sep 20, 2023
@JarbasAl JarbasAl force-pushed the feat/converse_session branch from b423c9c to 9605cb1 Compare September 20, 2023 23:42
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (6ceb058) 50.35% compared to head (8d78d08) 44.28%.
Report is 416 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #160      +/-   ##
==========================================
- Coverage   50.35%   44.28%   -6.08%     
==========================================
  Files         119       13     -106     
  Lines       10077     1827    -8250     
==========================================
- Hits         5074      809    -4265     
+ Misses       5003     1018    -3985     

see 95 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

JarbasAl added a commit to OpenVoiceOS/OVOS-workshop that referenced this pull request Sep 22, 2023
make get_response event based

companion PR to OpenVoiceOS/ovos-core#160
@JarbasAl JarbasAl modified the milestones: 0.0.7, 0.0.8 Sep 29, 2023
@JarbasAl JarbasAl force-pushed the feat/converse_session branch from 9605cb1 to 0adf031 Compare September 29, 2023 23:46
@JarbasAl JarbasAl merged commit f752ca7 into OpenVoiceOS:dev Sep 30, 2023
10 of 11 checks passed
@NeonJarbas NeonJarbas deleted the feat/converse_session branch January 6, 2024 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants