Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mycroft-bus-client -> ovos-bus-client #300

Merged
merged 11 commits into from
Apr 11, 2023
Merged

Conversation

JarbasAl
Copy link
Member

@JarbasAl JarbasAl commented Apr 8, 2023

splitting #292 in smaller PRs

other packages already moved to ovos-bus-client, core should also move without waiting for #292 which has a larger scope

@JarbasAl JarbasAl added the refactor code refactor without functional changes label Apr 8, 2023
@JarbasAl JarbasAl force-pushed the refactor/ovos-bus-client branch from c6a2edd to 35e327a Compare April 8, 2023 05:19
@JarbasAl JarbasAl added the packaging dependency updates or packaging changes label Apr 8, 2023
@JarbasAl JarbasAl requested review from NeonDaniel and a team April 8, 2023 05:28
@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Merging #300 (e688b0a) into dev (6ceb058) will decrease coverage by 0.14%.
The diff coverage is 41.40%.

@@            Coverage Diff             @@
##              dev     #300      +/-   ##
==========================================
- Coverage   50.35%   50.21%   -0.14%     
==========================================
  Files         119      156      +37     
  Lines       10077     8049    -2028     
==========================================
- Hits         5074     4042    -1032     
+ Misses       5003     4007     -996     
Impacted Files Coverage Δ
mycroft/api/__init__.py 0.00% <0.00%> (-78.23%) ⬇️
mycroft/audio/__main__.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/__main__.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/arduino.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/eyes.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/mouth.py 0.00% <0.00%> (ø)
mycroft/client/speech/__main__.py 0.00% <0.00%> (ø)
mycroft/client/speech/hotword_factory.py 0.00% <0.00%> (-88.89%) ⬇️
mycroft/client/speech/service.py 0.00% <0.00%> (ø)
mycroft/client/speech/silence.py 0.00% <0.00%> (-42.86%) ⬇️
... and 124 more

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@JarbasAl JarbasAl merged commit b1a9d39 into dev Apr 11, 2023
@JarbasAl JarbasAl deleted the refactor/ovos-bus-client branch April 11, 2023 07:33
@JarbasAl JarbasAl mentioned this pull request Apr 20, 2023
@JarbasAl JarbasAl added this to the 0.0.8 milestone Sep 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packaging dependency updates or packaging changes refactor code refactor without functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant