Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor and improve padatious matching #326

Merged
merged 3 commits into from
Jul 12, 2023
Merged

refactor and improve padatious matching #326

merged 3 commits into from
Jul 12, 2023

Conversation

JarbasAl
Copy link
Member

@JarbasAl JarbasAl commented Jun 2, 2023 •
edited
Loading

  • simplify padatious logic
  • use lru_cache decorator to avoid repeat calculations (as long as kwargs are the same)
  • use concurrent.futures

@JarbasAl JarbasAl added the refactor code refactor without functional changes label Jun 2, 2023
@JarbasAl JarbasAl requested review from goldyfruit, NeonDaniel and a team June 2, 2023 23:04
@JarbasAl JarbasAl requested a review from NeonDaniel June 2, 2023 23:28
@JarbasAl JarbasAl force-pushed the refactor/matching_performance branch from 0c78b92 to 9636a92 Compare June 19, 2023 16:04
@JarbasAl JarbasAl force-pushed the refactor/matching_performance branch from 7d8f70f to bcc3061 Compare July 7, 2023 19:07
@JarbasAl JarbasAl added bug Something isn't working tests and automation added unittests or github workflows labels Jul 7, 2023
@codecov
Copy link

codecov bot commented Jul 7, 2023 •
edited
Loading

Codecov Report

Merging #326 (6358661) into dev (6ceb058) will decrease coverage by 35.56%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##              dev     #326       +/-   ##
===========================================
- Coverage   50.35%   14.80%   -35.56%     
===========================================
  Files         119       11      -108     
  Lines       10077     1527     -8550     
===========================================
- Hits         5074      226     -4848     
+ Misses       5003     1301     -3702

see 93 files with indirect coverage changes

@JarbasAl
refactor and improve padatious matching
c060962 
merge _convert_intent into _match_level

revert rename

simplify

dont rename import for compat
@JarbasAl JarbasAl force-pushed the refactor/matching_performance branch from d2607da to c060962 Compare July 12, 2023 10:01
@JarbasAl JarbasAl removed bug Something isn't working tests and automation added unittests or github workflows labels Jul 12, 2023
@JarbasAl JarbasAl merged commit c068d85 into dev Jul 12, 2023
@JarbasAl JarbasAl deleted the refactor/matching_performance branch July 12, 2023 10:57
@JarbasAl JarbasAl mentioned this pull request Jul 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goldyfruit goldyfruit goldyfruit left review comments

@NeonDaniel NeonDaniel Awaiting requested review from NeonDaniel

Assignees
No one assigned
Labels
refactor code refactor without functional changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JarbasAl @goldyfruit @NeonDaniel