Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/ovos.utterance.handled #205

Merged
merged 1 commit into from
May 28, 2024
Merged

feat/ovos.utterance.handled #205

merged 1 commit into from
May 28, 2024

Conversation

JarbasAl
Copy link
Member

@JarbasAl JarbasAl commented May 28, 2024

companion to OpenVoiceOS/ovos-core#478

emits "ovos.utterance.handled" after intents and fallback skills, this is done here instead of core unlike the other pipelines in order to be able to happen after the intent code executes, as ovos-core just emits the event to trigger the intent and does not have that info

@JarbasAl JarbasAl added the enhancement New feature or request label May 28, 2024
@JarbasAl JarbasAl requested review from mikejgray, NeonDaniel and a team May 28, 2024 05:21
Copy link

codecov bot commented May 28, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 lines in your changes are missing coverage. Please review.

Please upload report for BASE (dev@fbc6ef9). Learn more about missing BASE report.

Files Patch % Lines
ovos_workshop/skills/ovos.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##             dev     #205   +/-   ##
======================================
  Coverage       ?   54.64%           
======================================
  Files          ?       36           
  Lines          ?     3920           
  Branches       ?        0           
======================================
  Hits           ?     2142           
  Misses         ?     1778           
  Partials       ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JarbasAl JarbasAl merged commit 57c1f5d into dev May 28, 2024
9 checks passed
@JarbasAl JarbasAl deleted the feat/ovos.utterance.handled branch May 28, 2024 05:26
@github-actions github-actions bot mentioned this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant