Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/ovos.utterance.handled #478

Merged
merged 5 commits into from
May 28, 2024
Merged

feat/ovos.utterance.handled #478

merged 5 commits into from
May 28, 2024

Conversation

JarbasAl
Copy link
Member

@JarbasAl JarbasAl commented May 21, 2024

emit a bus message when utterance is handled to unambigously identify when handling was completed. "ovos.utterance.handled"

requires OpenVoiceOS/OVOS-workshop#205

allows clients such as hivemind to know when to stop expecting more "speak" events

a concrete example from https://github.com/JarbasHiveMind/ovos-solver-hivemind-plugin

        # NOTE: this message not yet introduced in ovos-core
        self.hm.on_mycroft("ovos.utterance.handled", self._end_of_response)

        ##############
        # HACK - waiting for https://github.com/OpenVoiceOS/ovos-core/pull/478
        # TODO - new bus message in ovos-core
        #  to unambiguosly identify end of utterance handling
        #  currently these are 4 possible outcomes for any request
        #  does not account for OCP pipeline requests
        self.hm.on_mycroft("ovos.utterance.cancelled",
                           self._end_of_response)
        self.hm.on_mycroft("complete_intent_failure",
                           self._end_of_response)
        self.hm.on_mycroft("mycroft.skill.handler.complete",
                           self._end_of_response)
        self.hm.on_mycroft( "skill.converse.response",  # need to check if result is True
                           self._end_of_response)

also implements TODO for cancel sound file, sound does not exist and does not play by default, but can be added by a user

if in docker sound needs to be available to ovos-audio container

@JarbasAl JarbasAl added the enhancement New feature or request label May 21, 2024
@JarbasAl JarbasAl requested review from goldyfruit, builderjer and a team May 21, 2024 17:53
@JarbasAl JarbasAl marked this pull request as draft May 21, 2024 17:55
JarbasAl added a commit to JarbasHiveMind/ovos-solver-hivemind-plugin that referenced this pull request May 21, 2024
@JarbasAl JarbasAl modified the milestones: 0.0.8, 0.1.0 May 21, 2024
JarbasAl added 2 commits May 28, 2024 04:29
emit a bus message when utterance is handled to unambigously identify when handling was completed. "ovos.utterance.handled"

allows clients such as hivemind to know when to stop expecting more "speak" events

also implements TODO for cancel sound, sound does not exist and does not play by default
@JarbasAl JarbasAl force-pushed the feat/ovos.utterance.handled branch from 5dcef58 to 027829d Compare May 28, 2024 05:17
JarbasAl added a commit to OpenVoiceOS/OVOS-workshop that referenced this pull request May 28, 2024
JarbasAl added a commit to OpenVoiceOS/OVOS-workshop that referenced this pull request May 28, 2024
@JarbasAl JarbasAl marked this pull request as ready for review May 28, 2024 05:45
Copy link

codecov bot commented May 28, 2024

Codecov Report

Attention: Patch coverage is 81.69014% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 74.31%. Comparing base (87b756b) to head (6375dc1).
Report is 1 commits behind head on dev.

Files Patch % Lines
ovos_core/intent_services/__init__.py 71.05% 11 Missing ⚠️
ovos_core/intent_services/commonqa_service.py 0.00% 1 Missing ⚠️
ovos_core/intent_services/stop_service.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #478      +/-   ##
==========================================
- Coverage   74.54%   74.31%   -0.24%     
==========================================
  Files          15       15              
  Lines        2833     2815      -18     
==========================================
- Hits         2112     2092      -20     
- Misses        721      723       +2     
Flag Coverage Δ
unittests 74.31% <81.69%> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JarbasAl JarbasAl merged commit 3cf75ed into dev May 28, 2024
8 checks passed
@JarbasAl JarbasAl deleted the feat/ovos.utterance.handled branch May 28, 2024 06:11
@JarbasAl JarbasAl modified the milestones: 0.1.0, 0.0.8 May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant