forked from MycroftAI/mycroft-core
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/ovos.utterance.handled #478
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JarbasAl
added a commit
to JarbasHiveMind/ovos-solver-hivemind-plugin
that referenced
this pull request
May 21, 2024
companion to OpenVoiceOS/ovos-core#478
emit a bus message when utterance is handled to unambigously identify when handling was completed. "ovos.utterance.handled" allows clients such as hivemind to know when to stop expecting more "speak" events also implements TODO for cancel sound, sound does not exist and does not play by default
JarbasAl
force-pushed
the
feat/ovos.utterance.handled
branch
from
May 28, 2024 05:17
5dcef58
to
027829d
Compare
JarbasAl
added a commit
to OpenVoiceOS/OVOS-workshop
that referenced
this pull request
May 28, 2024
companion to OpenVoiceOS/ovos-core#478
JarbasAl
added a commit
to OpenVoiceOS/OVOS-workshop
that referenced
this pull request
May 28, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #478 +/- ##
==========================================
- Coverage 74.54% 74.31% -0.24%
==========================================
Files 15 15
Lines 2833 2815 -18
==========================================
- Hits 2112 2092 -20
- Misses 721 723 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
emit a bus message when utterance is handled to unambigously identify when handling was completed.
"ovos.utterance.handled"
requires OpenVoiceOS/OVOS-workshop#205
allows clients such as hivemind to know when to stop expecting more
"speak"
eventsa concrete example from https://github.com/JarbasHiveMind/ovos-solver-hivemind-plugin
also implements TODO for cancel sound file, sound does not exist and does not play by default, but can be added by a user