Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add is_intent kwarg to MycroftSkill class to resolve errors #207

Merged
merged 1 commit into from
May 31, 2024

Conversation

NeonDaniel
Copy link
Member

Continues #205
Issue noted and fix tested in NeonGeckoCom/neon-utils#528

@NeonDaniel NeonDaniel requested a review from a team May 31, 2024 17:11
Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (dev@dab4956). Learn more about missing BASE report.

Additional details and impacted files
@@          Coverage Diff           @@
##             dev     #207   +/-   ##
======================================
  Coverage       ?   54.64%           
======================================
  Files          ?       36           
  Lines          ?     3920           
  Branches       ?        0           
======================================
  Hits           ?     2142           
  Misses         ?     1778           
  Partials       ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JarbasAl JarbasAl merged commit 9156940 into dev May 31, 2024
9 checks passed
@JarbasAl JarbasAl deleted the FIX_MycroftSkillCompat branch May 31, 2024 18:07
@JarbasAl JarbasAl added the bug Something isn't working label May 31, 2024
@JarbasAl
Copy link
Member

duplicated from #206 , but i'll rebase

@github-actions github-actions bot mentioned this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants