[18.0][MIG] account_reconcile_model_oca: Migration to 18.0 #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently translated at 100.0% (2 of 2 strings) Translation: account-reconcile-17.0/account-reconcile-17.0-account_reconcile_model_oca Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-17-0/account-reconcile-17-0-account_reconcile_model_oca/it/
Due to latest copier template with all the checks.
Currently translated at 100.0% (2 of 2 strings) Translation: account-reconcile-17.0/account-reconcile-17.0-account_reconcile_model_oca Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-17-0/account-reconcile-17-0-account_reconcile_model_oca/zh_CN/
This was referenced Nov 7, 2024
mmequignon
approved these changes
Nov 7, 2024
Comment on lines
+68
to
+77
| SQL( | ||
| rf""" | ||
| {unaccent("%s")} ~* ('^' || ( | ||
| SELECT STRING_AGG(CONCAT('(?=.*\m', chunk[1], '\M)'), '') | ||
| FROM regexp_matches({unaccent('partner.name')}, '\w{{3,}}', 'g') | ||
| AS chunk | ||
| )) | ||
| """, | ||
| text_value, | ||
| ) |
There was a problem hiding this comment.
Why not adding the wrapping parenthesis here, in order to avoid the ugly extra parenthesis in the query parts every where else:
query = "[...] ("final = ") [...]"parts = ") OR (".join(subqueries)
which IMO is more complicated to read/understand.
|
Are we not missing some commits from 17.0 https://github.com/OCA/account-reconcile/commits/17.0/account_reconcile_oca ? |
hi @TDu, Maybe you a little confused about between |
account_reconcile_model_oca/models/account_bank_statement_line.py
Outdated
Show resolved
Hide resolved
xaviedoanhduy
force-pushed
the
18.0-mig-account_reconcile_model_oca
branch
from
c4d1fad
to
ab10b31
Compare
xaviedoanhduy
force-pushed
the
18.0-mig-account_reconcile_model_oca
branch
from
ab10b31
to
0d217b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change in v18
get_sqlhas removed in odoo/odoo@5c397d5account_journal_payment_credit_account_idhas removed in odoo/odoo@01b87f1depend on