Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] account_statement_import_file: Migration to 18.0 #736

Open
wants to merge 23 commits into
base: 18.0
Choose a base branch
from

Conversation

xaviedoanhduy
Copy link

@xaviedoanhduy xaviedoanhduy commented Nov 7, 2024

depends on:

change in v18

  • menu menu_finance_entries_actions (Accounting/Actions) was removed in commit: odoo/odoo@70a2618

alexis-via and others added 21 commits November 7, 2024 15:53
The module was renamed from account_statement_import to account_statement_import_file.
The migration has been done from v14 to v16, to take into account the big changes that took place in v14 with the introduction of the module account_statement_import_base. The changes from v15 have been forward-ported to v16.
Currently translated at 100.0% (36 of 36 strings)

Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_file
Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_file/hr/
Currently translated at 100.0% (36 of 36 strings)

Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_file
Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_file/es/
Currently translated at 100.0% (36 of 36 strings)

Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_file
Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_file/fr/
Currently translated at 58.3% (21 of 36 strings)

Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_file
Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_file/pt_BR/
Currently translated at 100.0% (36 of 36 strings)

Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_file
Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_file/pt_BR/
Currently translated at 100.0% (36 of 36 strings)

Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_file
Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_file/es/
Currently translated at 100.0% (36 of 36 strings)

Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_file
Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_file/ca/
Currently translated at 72.2% (26 of 36 strings)

Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_file
Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_file/it/
Currently translated at 100.0% (36 of 36 strings)

Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_file
Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_file/it/
Currently translated at 100.0% (36 of 36 strings)

Translation: bank-statement-import-17.0/bank-statement-import-17.0-account_statement_import_file
Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-17-0/bank-statement-import-17-0-account_statement_import_file/sv/
Currently translated at 100.0% (36 of 36 strings)

Translation: bank-statement-import-17.0/bank-statement-import-17.0-account_statement_import_file
Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-17-0/bank-statement-import-17-0-account_statement_import_file/zh_CN/
Comment on lines 39 to 41
f_path = file_path(
"account_statement_import_file/test_files/test_statement_import.txt"
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why ? This file is only used in unittests no? Why extracting this in another folder?

Copy link
Author

@xaviedoanhduy xaviedoanhduy Nov 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @mmequignon,
you're right, it should be in the /tests/samples folder because there is a convention for that type of file in


so on this occasion, i have moved it to the /tests/samples folder

@xaviedoanhduy xaviedoanhduy force-pushed the 18.0-mig-account_statement_import_file branch from 27ef63d to 51ded18 Compare November 26, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.