[18.0][MIG] account_statement_base: Migration to 18.0 #739

xaviedoanhduy · 2024-11-07T08:32:09Z

change in v18

checked was replace to_checked fields in commit: odoo/odoo@242e1a0

This module contains the views of account.bank.statement.line, which have been removed from the account module in Odoo v16

The module account_statement_base will be used by the modules from OCA/bank-statement-import which are LGPL (because they initially came from Odoo official addons), so it cannot be AGPL.

* refactoring JS in order to add logic * Improve views * Minor fixes in Odoo code in order to fix all possible options

Currently translated at 100.0% (12 of 12 strings) Translation: account-reconcile-16.0/account-reconcile-16.0-account_statement_base Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-16-0/account-reconcile-16-0-account_statement_base/pt_BR/

Currently translated at 100.0% (12 of 12 strings) Translation: account-reconcile-16.0/account-reconcile-16.0-account_statement_base Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-16-0/account-reconcile-16-0-account_statement_base/es/

Currently translated at 100.0% (12 of 12 strings) Translation: account-reconcile-16.0/account-reconcile-16.0-account_statement_base Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-16-0/account-reconcile-16-0-account_statement_base/fr/

Currently translated at 100.0% (12 of 12 strings) Translation: account-reconcile-17.0/account-reconcile-17.0-account_statement_base Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-17-0/account-reconcile-17-0-account_statement_base/it/

Currently translated at 100.0% (12 of 12 strings) Translation: account-reconcile-17.0/account-reconcile-17.0-account_statement_base Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-17-0/account-reconcile-17-0-account_statement_base/zh_CN/

Make them listed and editable

Before this commit, when a user clicked the "New Transaction" button, an error was raised. After this commit, statement lines are displayed to create new records.

Currently translated at 100.0% (15 of 15 strings) Translation: account-reconcile-17.0/account-reconcile-17.0-account_statement_base Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-17-0/account-reconcile-17-0-account_statement_base/it/

…ent lines to the associated journal entry through a button. Adds also the journal entry number as an optional field

…model_oca tests

… to create the statement lines linked to it TT51767

…ing on the New button (only on cash ones). If you access the list of statements from the Create button, you should be able to create new records. TT51767

xaviedoanhduy · 2024-11-20T09:35:54Z

hi @victoralmau, Done!

victoralmau · 2024-11-20T09:37:52Z

Thanks, I think you forgot the commit [FIX] account_statement_base: Remove wrong field label from #751

xaviedoanhduy · 2024-11-20T09:39:53Z

account_statement_base/views/account_bank_statement_line.xml

@@ -14,7 +14,7 @@
                    <field name="company_id" invisible="1" />
                    <field name="currency_id" invisible="1" />
                    <field name="country_code" invisible="1" />
-                    <field5c1485a3 name="state" invisible="1" />


hi @victoralmau, during migration state, I fixed it

victoralmau

Have you functionally tested the module? I'm not sure why but if you install account_statement_base and add the corresponding permission it doesn't show the Dashboard menu in Invoicing, can you check it?

account_statement_base/views/account_bank_statement.xml

xaviedoanhduy · 2024-11-20T20:50:10Z

Have you functionally tested the module? I'm not sure why but if you install account_statement_base and add the corresponding permission it doesn't show the Dashboard menu in Invoicing, can you check it?

hi @victoralmau, have conditions to see this action in here

victoralmau

Code and functional review OK

pedrobaeza

/ocabot migration account_statement_base
/ocabot merge nobump

OCA-git-bot · 2024-11-22T12:24:38Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 18.0-ocabot-merge-pr-739-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2024-11-22T12:24:40Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot · 2024-11-22T12:28:51Z

Congratulations, your PR was merged at b18e7aa. Thanks a lot for contributing to OCA. ❤️

alexis-via and others added 30 commits November 7, 2024 15:35

[ADD] module account_statement_base

4419ce7

This module contains the views of account.bank.statement.line, which have been removed from the account module in Odoo v16

[ADD] icon.png

3e2c038

account_statement_base: change licence to LGPL

d855ad8

The module account_statement_base will be used by the modules from OCA/bank-statement-import which are LGPL (because they initially came from Odoo official addons), so it cannot be AGPL.

account_statement_base 16.0.1.1.0

f9c3da5

account_statement_base: add development_status in manifest

3fc4a5c

account_statement_base 16.0.1.2.0

a68da82

[IMP] account_reconcile_oca: Finish creation of module

88906e6

* refactoring JS in order to add logic * Improve views * Minor fixes in Odoo code in order to fix all possible options

[IMP] account_statement_base: add form to statement view_mode

4c52f54

account_statement_base 16.0.1.3.0

30442b9

Added translation using Weblate (Portuguese (Brazil))

20a1403

Added translation using Weblate (Spanish)

4f3d414

Added translation using Weblate (French)

1694a97

[IMP] account_statement_base: pre-commit auto fixes

aa4249e

[MIG] account_statement_base: Migration to 17.0

1a3df69

[BOT] post-merge updates

1d037bd

Added translation using Weblate (Italian)

7e9e319

Added translation using Weblate (Chinese (zh))

2314ece

Added translation using Weblate (Chinese (Simplified) (zh_CN))

c2d9803

[IMP] account_statement_base: Set tree views

49a97c0

Make them listed and editable

[IMP] account_statement_base: Add statement form view

ba38bce

[IMP] account_statement_base: Show action to create Statements

da935f2

Before this commit, when a user clicked the "New Transaction" button, an error was raised. After this commit, statement lines are displayed to create new records.

[IMP] account_statement_base: Add extra fields

1f2258d

[BOT] post-merge updates

2b673a7

[IMP] account_statement_base: add possibility to navigate from statem…

dbf359c

…ent lines to the associated journal entry through a button. Adds also the journal entry number as an optional field

xaviedoanhduy force-pushed the 18.0-mig-account_statement_base branch from 0f0eb15 to bd661c0 Compare November 20, 2024 09:27

xaviedoanhduy and others added 4 commits November 20, 2024 16:29

[IMP] account_statement_base: no need to depend on account_reconcile_…

49bd91e

…model_oca tests

[FIX] account_statement_base: Add default_statement_id to the context…

4e1cca2

… to create the statement lines linked to it TT51767

[FIX] account_statement_base: Allow statements to be created by click…

a644726

…ing on the New button (only on cash ones). If you access the list of statements from the Create button, you should be able to create new records. TT51767

[IMP] account_statement_base: pre-commit auto fixes

35e8057

xaviedoanhduy force-pushed the 18.0-mig-account_statement_base branch 2 times, most recently from 2eb9182 to 10cc464 Compare November 20, 2024 09:31

xaviedoanhduy commented Nov 20, 2024

View reviewed changes

victoralmau suggested changes Nov 20, 2024

View reviewed changes

account_statement_base/views/account_bank_statement.xml Outdated Show resolved Hide resolved

OCA-git-bot removed approved ready to merge labels Nov 20, 2024

[MIG] account_statement_base: Migration to 18.0

4df6e7b

xaviedoanhduy force-pushed the 18.0-mig-account_statement_base branch from 10cc464 to 4df6e7b Compare November 20, 2024 20:33

xaviedoanhduy requested a review from victoralmau November 20, 2024 20:50

victoralmau approved these changes Nov 22, 2024

View reviewed changes

OCA-git-bot added the approved label Nov 22, 2024

pedrobaeza approved these changes Nov 22, 2024

View reviewed changes

OCA-git-bot added this to the 18.0 milestone Nov 22, 2024

OCA-git-bot added bot is merging ⏳ ready to merge labels Nov 22, 2024

OCA-git-bot merged commit e6be9b6 into OCA:18.0 Nov 22, 2024
7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Nov 22, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[18.0][MIG] account_statement_base: Migration to 18.0 #739

[18.0][MIG] account_statement_base: Migration to 18.0 #739

xaviedoanhduy commented Nov 7, 2024 •

edited

Loading

xaviedoanhduy commented Nov 20, 2024

victoralmau commented Nov 20, 2024

xaviedoanhduy Nov 20, 2024 •

edited

Loading

victoralmau left a comment

xaviedoanhduy commented Nov 20, 2024 •

edited

Loading

victoralmau left a comment

pedrobaeza left a comment

OCA-git-bot commented Nov 22, 2024

OCA-git-bot commented Nov 22, 2024

OCA-git-bot commented Nov 22, 2024

[18.0][MIG] account_statement_base: Migration to 18.0 #739

[18.0][MIG] account_statement_base: Migration to 18.0 #739

Conversation

xaviedoanhduy commented Nov 7, 2024 • edited Loading

change in v18

xaviedoanhduy commented Nov 20, 2024

victoralmau commented Nov 20, 2024

xaviedoanhduy Nov 20, 2024 • edited Loading

Choose a reason for hiding this comment

victoralmau left a comment

Choose a reason for hiding this comment

xaviedoanhduy commented Nov 20, 2024 • edited Loading

victoralmau left a comment

Choose a reason for hiding this comment

pedrobaeza left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Nov 22, 2024

OCA-git-bot commented Nov 22, 2024

OCA-git-bot commented Nov 22, 2024

xaviedoanhduy commented Nov 7, 2024 •

edited

Loading

xaviedoanhduy Nov 20, 2024 •

edited

Loading

xaviedoanhduy commented Nov 20, 2024 •

edited

Loading