python312Packages.pyside6: fix eval on linux #356081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbsds
changed the title
This was referenced Nov 15, 2024
K900
reviewed
Nov 15, 2024
| python.pkgs.packaging | ||
| python.pkgs.setuptools | ||
| ] | ||
| ++ lib.optional stdenv.hostPlatform.isDarwin [ |
There was a problem hiding this comment.
No longer confident the fix is correct 🫠
There was a problem hiding this comment.
it's so annoying that toString doesn't care about nested lists. We should at some point make structured attrs default
There was a problem hiding this comment.
It’s being worked on ^^ #205690
Optimistically, we might be able to flip the default for 25.05.
pbsds
force-pushed
the
fix-pyside6-1731648734
branch
from
3a37005 to
6bd56f2
Compare
|
Successfully created backport PR for |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zhf #352882
fixes #356072
i've yet to see the build complete, buti'm now off to bedThings done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.