Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

normcap: 0.5.8 -> 0.5.9 #355312

Merged
merged 1 commit into from
Nov 28, 2024
Merged

normcap: 0.5.8 -> 0.5.9 #355312

merged 1 commit into from
Nov 28, 2024

Conversation

pbsds
Copy link
Member

@pbsds pbsds commented Nov 12, 2024 •
edited
Loading

Changelog: https://github.com/dynobo/normcap/releases/tag/v0.5.9

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@pbsds pbsds marked this pull request as ready for review November 12, 2024 00:47
@ofborg ofborg bot requested a review from cafkafk November 12, 2024 13:45
@pbsds
Copy link
Member Author

pbsds commented Nov 12, 2024

@ofborg eval

@cafkafk
Copy link
Member

cafkafk commented Nov 14, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 355312

x86_64-linux

⏩ 2 packages marked as broken and skipped:
  • normcap
  • normcap.dist

@cafkafk
Copy link
Member

cafkafk commented Nov 14, 2024 •
edited
Loading

I'm not sure why this is marked as broken... (by nixpkgs-review, because it seems to build/run fine)

@pbsds
Copy link
Member Author

pbsds commented Nov 14, 2024

It seems pyside6-6.8.0.2 on master now depends on the apple-sdk, even when system is x86_64-linux

@pbsds
Copy link
Member Author

pbsds commented Nov 15, 2024

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 23, 2024
@pbsbot
Copy link

pbsbot commented Nov 23, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 355312

x86_64-linux

✅ 2 packages built:
  • normcap
  • normcap.dist

@donovanglover donovanglover added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Nov 25, 2024
@donovanglover donovanglover merged commit fa42b5a into NixOS:master Nov 28, 2024
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FliegendeWurst FliegendeWurst FliegendeWurst approved these changes

@donovanglover donovanglover donovanglover approved these changes

@cafkafk cafkafk Awaiting requested review from cafkafk

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pbsds @cafkafk @pbsbot @donovanglover @FliegendeWurst @wegank