Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qt6: expose darwinVersionInputs; python312Packages.{shiboken6,pyside6}: use qt6.darwinVersionInputs #354599

Merged
merged 3 commits into from
Nov 10, 2024

Conversation

emilazy
Copy link
Member

@emilazy emilazy commented Nov 8, 2024

Should fix the build.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

This is a little gross as it’s not a very good name and should
really be considered an internal API, but PySide wants it.
@ofborg ofborg bot requested a review from gebner November 9, 2024 04:10
@K900 K900 merged commit 73cdc95 into NixOS:staging-next Nov 10, 2024
29 of 30 checks passed
@emilazy emilazy deleted the push-lxullrrqrxnq branch November 10, 2024 08:27
@SigmaSquadron
Copy link
Contributor

SigmaSquadron commented Nov 15, 2024

Maybe I'm holding staging-next PRs wrong, but I'm pretty sure this PR broke evaluation of pyside6 on non-Darwin platforms. OfBorg skipped building it, as it now depends on apple-sdk-15.0 on Linux. Naturally, this also broke any package that depends on pyside6. (including kdePackages.falkon, which is how I got to this issue)

@pbsds
Copy link
Member

pbsds commented Nov 15, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants