Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the frontend to match the backend #17

Merged
merged 26 commits into from
Oct 2, 2024
Merged

Update the frontend to match the backend #17

merged 26 commits into from
Oct 2, 2024

Conversation

wheelsandcogs
Copy link
Collaborator

@wheelsandcogs wheelsandcogs commented Sep 27, 2024 •
edited
Loading

Various updates to sync the frontend with the backend changes in Marvell-Consulting/statswales-backend#18

  • use a similar config system to the backend
  • update eslint and use the same rules
  • update DTOs to match backend
  • use consistent filenaming
  • bump dependencies where possible

NOTE: msw has been locked at 2.4.3 for the time being as 2.4.4 onwards causes issues with supertest.attach().

github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 27, 2024
View reviewed changes
src/config/envs/ci.ts Fixed Show fixed Hide fixed
src/config/envs/local.ts Dismissed Show dismissed Hide dismissed
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 1, 2024
View reviewed changes
src/config/envs/ci.ts Dismissed Show dismissed Hide dismissed
@wheelsandcogs wheelsandcogs changed the title WIP Fix/linting Update the frontend to match the backend Oct 1, 2024
j-maynard
j-maynard approved these changes Oct 1, 2024
View reviewed changes
Copy link
Collaborator

@j-maynard j-maynard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@wheelsandcogs wheelsandcogs merged commit 958a96d into main Oct 2, 2024
3 checks passed
@wheelsandcogs wheelsandcogs deleted the fix/linting branch October 2, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-maynard j-maynard j-maynard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wheelsandcogs @j-maynard