Merge pull request #17 from Marvell-Consulting/fix/linting

Update the frontend to match the backend

.github/workflows/node-test.yml

@@ -27,6 +27,7 @@ jobs:
         node-version: ${{ matrix.node-version }}
         cache: 'npm'
     - run: npm ci
-    - run: npm run build --if-present
-    - run: npm test
-
+    - run: npm run prettier:ci
+    - run: npm run lint:ci
+    - run: npm run build
+    - run: npm run test:ci

docker-compose.yml

@@ -0,0 +1,5 @@
+services:
+  redis:
+    image: redis:latest
+    ports:
+      - "6380:6379"

eslint.config.mjs

@@ -0,0 +1,46 @@
+// @ts-check
+import shopifyEslintPlugin from '@shopify/eslint-plugin';
+
+export default [
+  {
+    // global ignores need to be in their own block otherwise they don't seem to work
+    ignores: [
+      '.github/**',
+      '.vscode/**',
+      'coverage/**',
+      'dist/**',
+      'node_modules/**',
+      'src/public/**',
+      '**/*.config.{mjs,ts}'
+    ],
+  },
+  ...shopifyEslintPlugin.configs.typescript,
+  ...shopifyEslintPlugin.configs.prettier,
+  {
+    rules: {
+      'line-comment-position': 'off',
+      'no-warning-comments': 'warn',
+      'no-process-env': 'warn',
+      '@typescript-eslint/member-ordering': 'off',
+      '@typescript-eslint/naming-convention': [
+        'error',
+        {
+          selector: 'default',
+          format: ['camelCase', 'PascalCase', 'UPPER_CASE', 'snake_case'],
+        }
+      ],
+    }
+  },
+  {
+    files: ['src/config/**/*.ts', 'test/.jest/set-env-vars.ts'],
+    rules: {
+      'no-process-env': 'off',
+    }
+  },
+  {
+    files: ['test/**/*.ts'],
+    rules: {
+      'no-console': 'off',
+    }
+  },
+];

jest.config.ts

@@ -9,7 +9,7 @@ const config: Config = {
   collectCoverage: true,
   coverageReporters: ['cobertura', 'lcov', 'html', 'text'],
   coveragePathIgnorePatterns: ['/node_modules/', '/test/', '/src/controllers/datalake.ts'],
-  setupFiles: ['<rootDir>/test/.jest/setEnvVars.ts']
+  setupFiles: ['<rootDir>/test/.jest/set-env-vars.ts']
 };
 
 export default config;