Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the frontend to match the backend #17

Merged
merged 26 commits into from
Oct 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
35a78f1
sync DTO changes from backend
wheelsandcogs Sep 27, 2024
4a3210f
remove 2 from dto dir name
wheelsandcogs Sep 27, 2024
8a43f01
use new eslint conf
wheelsandcogs Sep 27, 2024
c2ab6f2
separate linting step
wheelsandcogs Sep 27, 2024
0d323b2
lint fixes
wheelsandcogs Sep 27, 2024
b146879
update ci session config
wheelsandcogs Sep 30, 2024
02fad6d
fix session in local & CI
wheelsandcogs Sep 30, 2024
0d43cd1
fix source type
wheelsandcogs Sep 30, 2024
0e355d0
try and fix publish tests
wheelsandcogs Sep 30, 2024
3687a35
fix ci
wheelsandcogs Sep 30, 2024
13fe70b
undo commenting out of user agent
wheelsandcogs Sep 30, 2024
3c9a057
move check later
wheelsandcogs Oct 1, 2024
153b01e
hardcode ci vars
wheelsandcogs Oct 1, 2024
96c5cb0
add debugging
wheelsandcogs Oct 1, 2024
9d12bd4
more debug
wheelsandcogs Oct 1, 2024
b3c4d86
works without the attach
wheelsandcogs Oct 1, 2024
72e3fb6
lock [email protected] to prevent test fails
wheelsandcogs Oct 1, 2024
3fff1dd
re-enable tests
wheelsandcogs Oct 1, 2024
39a861c
fix all the tests
wheelsandcogs Oct 1, 2024
09292d5
fix filename
wheelsandcogs Oct 1, 2024
be247ac
force msw 2.4.3 until we find non-breaking solution
wheelsandcogs Oct 1, 2024
799476d
remove enum suffix
wheelsandcogs Oct 1, 2024
f74643e
use interface instead of class
wheelsandcogs Oct 1, 2024
5d1831e
downgrade to TS 5.5 until 5.6 is supported by @typescript-eslint/type…
wheelsandcogs Oct 1, 2024
a6dfe37
remove console.logs
wheelsandcogs Oct 1, 2024
f437667
typed log level
wheelsandcogs Oct 1, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .eslintignore

This file was deleted.

30 changes: 0 additions & 30 deletions .eslintrc

This file was deleted.

7 changes: 4 additions & 3 deletions .github/workflows/node-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ jobs:
node-version: ${{ matrix.node-version }}
cache: 'npm'
- run: npm ci
- run: npm run build --if-present
- run: npm test

- run: npm run prettier:ci
- run: npm run lint:ci
- run: npm run build
- run: npm run test:ci
5 changes: 5 additions & 0 deletions docker-compose.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
services:
redis:
image: redis:latest
ports:
- "6380:6379"
46 changes: 46 additions & 0 deletions eslint.config.mjs
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
// @ts-check
import shopifyEslintPlugin from '@shopify/eslint-plugin';

export default [
{
// global ignores need to be in their own block otherwise they don't seem to work
ignores: [
'.github/**',
'.vscode/**',
'coverage/**',
'dist/**',
'node_modules/**',
'src/public/**',
'**/*.config.{mjs,ts}'
],
},
...shopifyEslintPlugin.configs.typescript,
...shopifyEslintPlugin.configs.prettier,
{
rules: {
'line-comment-position': 'off',
'no-warning-comments': 'warn',
'no-process-env': 'warn',
'@typescript-eslint/member-ordering': 'off',
'@typescript-eslint/naming-convention': [
'error',
{
selector: 'default',
format: ['camelCase', 'PascalCase', 'UPPER_CASE', 'snake_case'],
}
],
}
},
{
files: ['src/config/**/*.ts', 'test/.jest/set-env-vars.ts'],
rules: {
'no-process-env': 'off',
}
},
{
files: ['test/**/*.ts'],
rules: {
'no-console': 'off',
}
},
];
2 changes: 1 addition & 1 deletion jest.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ const config: Config = {
collectCoverage: true,
coverageReporters: ['cobertura', 'lcov', 'html', 'text'],
coveragePathIgnorePatterns: ['/node_modules/', '/test/', '/src/controllers/datalake.ts'],
setupFiles: ['<rootDir>/test/.jest/setEnvVars.ts']
setupFiles: ['<rootDir>/test/.jest/set-env-vars.ts']
};

export default config;
Loading
Loading