Add back meta-device assign=True loading in merge_lora
#1250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d8dc97e.
carmocca
changed the title
merge_lora
awaelchli
reviewed
Apr 4, 2024
carmocca
changed the title
merge_loraassign=True loading in merge_lora
|
@awaelchli Do you want to review this again or am I good to merge this? |
|
@carmocca I lost a bit track of the intermediate changes that happened between my commit and this revert. But I'm good with merging if we're confident it was fixed properly. Ultimately, what needs to work is being able to merge a base model in float16 and a lora checkpoint in bfloat16, or vice versa. Which I think is covered in this test now: https://github.com/Lightning-AI/litgpt/pull/1251/files |
awaelchli
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit d8dc97e.