Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rely on type promotion for LoRA merge #1248

Merged
merged 2 commits into from
Apr 9, 2024
Merged

Rely on type promotion for LoRA merge #1248

merged 2 commits into from
Apr 9, 2024

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Apr 4, 2024

Closes #1246

@carmocca carmocca self-assigned this Apr 4, 2024
@carmocca carmocca mentioned this pull request Apr 4, 2024
Merged
@carmocca carmocca marked this pull request as ready for review April 4, 2024 16:32
@carmocca carmocca requested a review from lantiga as a code owner April 4, 2024 16:32
@carmocca carmocca mentioned this pull request Apr 4, 2024
Merged
@carmocca carmocca mentioned this pull request Apr 5, 2024
Closed
@carmocca carmocca merged commit dc1945c into main Apr 9, 2024
7 of 8 checks passed
@carmocca carmocca deleted the carmocca/merge-type-promotion branch April 9, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awaelchli awaelchli awaelchli left review comments

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

Assignees

@carmocca carmocca

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carmocca @awaelchli