Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parametrize merge_lora test with different dtypes #1251

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Apr 4, 2024

Adds a test that would have failed before #1246

And aims to make sure that #1250 and #1248 are valid alternatives to reverting the assign=True change (acts as a test for both PRs)

@carmocca carmocca self-assigned this Apr 4, 2024
@carmocca carmocca merged commit c634a28 into main Apr 4, 2024
8 checks passed
@carmocca carmocca deleted the carmocca/parametrize-merge-lora branch April 4, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant