Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update StreamSwiftTestHelpers #376

Merged
merged 9 commits into from
Oct 26, 2023
Merged

Update StreamSwiftTestHelpers #376

merged 9 commits into from
Oct 26, 2023

Conversation

testableapple
Copy link
Contributor

@testableapple testableapple commented Oct 5, 2023 •
edited
Loading

🔗 Issue Links

Resolves https://github.com/GetStream/ios-issues-tracking/issues/579
Resolves https://github.com/GetStream/ios-issues-tracking/issues/539
Relates to GetStream/stream-chat-swift#2828

📝 Summary

  • StreamChatTestHelpers is removed from StreamChat's Package.swift
  • StreamChatTestHelpers is renamed to StreamSwiftTestHelpers
  • SnapshotTesting extracted into StreamSwiftTestHelpers
  • SnapshotTesting version bumped to better work on Xcode 15

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero ⚠️ policy (required)
  • This change should be manually QAed
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (docusaurus, tutorial, CMS)

🎁 Meme

gif

@testableapple testableapple force-pushed the ci/spm branch 4 times, most recently from af1bb6d to fa11832 Compare October 5, 2023 13:54
@testableapple testableapple mentioned this pull request Oct 5, 2023
Merged
10 tasks
@testableapple testableapple added the 🤖 CI/CD Any work related to CI/CD label Oct 5, 2023
@github-actions
Copy link

github-actions bot commented Oct 9, 2023

1 Error
🚫 Please use more than one word.
d9fa59a

Generated by 🚫 Danger

@testableapple testableapple marked this pull request as ready for review October 9, 2023 13:46
@testableapple testableapple requested a review from a team as a code owner October 9, 2023 13:46
martinmitrevski
martinmitrevski reviewed Oct 9, 2023
View reviewed changes
Copy link
Contributor

@martinmitrevski martinmitrevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but as you said, let's wait before merging this.

StreamChatSwiftUI.xcodeproj/project.pbxproj Outdated Show resolved Hide resolved
StreamChatSwiftUITests/Tests/ChatChannel/ChannelInfo/AddUsersView_Tests.swift Show resolved Hide resolved
@testableapple testableapple changed the title Update StreamSwiftTestHelpers [Waiting for release] Update StreamSwiftTestHelpers Oct 9, 2023
@testableapple testableapple mentioned this pull request Oct 20, 2023
Merged
6 tasks
@martinmitrevski martinmitrevski changed the title [Waiting for release] Update StreamSwiftTestHelpers Update StreamSwiftTestHelpers Oct 26, 2023
@testableapple testableapple merged commit e83d8ac into main Oct 26, 2023
2 of 3 checks passed
@testableapple testableapple deleted the ci/spm branch October 26, 2023 13:36
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 169 Code Smells

28.1% 28.1% Coverage
7.0% 7.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinmitrevski martinmitrevski martinmitrevski approved these changes

Assignees
No one assigned
Labels
🤖 CI/CD Any work related to CI/CD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@testableapple @martinmitrevski