Embedding third-party dependencies #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
testableapple
changed the title
Generated by 🚫 Danger |
testableapple
commented
Oct 19, 2023
Comment on lines
92
to
99
| } | ||
| doubleTapCancellable = doubleTap.sink { [unowned self] in handleDoubleTap() } | ||
| } as! any Cancellable // FIXME | ||
| doubleTapCancellable = doubleTap.sink { [unowned self] in handleDoubleTap() } as! any Cancellable // FIXME | ||
| } | ||
|
|
||
| func update(content: Content, doubleTap: AnyPublisher<Void, Never>) { | ||
| coordinator.hostingController.rootView = content | ||
| scrollView.setNeedsUpdateConstraints() | ||
| doubleTapCancellable = doubleTap.sink { [unowned self] in handleDoubleTap() } | ||
| doubleTapCancellable = doubleTap.sink { [unowned self] in handleDoubleTap() } as! any Cancellable // FIXME |
There was a problem hiding this comment.
@martinmitrevski, could you please take a look at what went wrong here?
testableapple
force-pushed
the
ci/embed-dependencies
branch
from
2c64599 to
1ebe09b
Compare
martinmitrevski
approved these changes
Oct 20, 2023
CHANGELOG.md
Outdated
| @@ -3,6 +3,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/). | |||
|
|
|||
| # Upcoming | |||
|
|
|||
| ### ⚠️ Important | |||
|
|
|||
| - Dependencies are no longer exposed (this includes Nuke and SwiftyGif). If you were using those dependencies we were exposing, you would need to import them manually. | |||
There was a problem hiding this comment.
Maybe also add that they should "Reset package caches" after integrating? I had issues until I did that.
| ], | ||
| targets: [ | ||
| .target( | ||
| name: "StreamChatSwiftUI", | ||
| dependencies: [.product(name: "StreamChat", package: "stream-chat-swift"), "Nuke", .product(name: "NukeUI", package: "Nuke")], |
There was a problem hiding this comment.
I still see Difference, Swifter and the tools. Can we also get rid of those? (not in this PR)
There was a problem hiding this comment.
Those come from StreamChat. They will be gone as soon as #376 is merged
|
SonarCloud Quality Gate failed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Link
Resolve https://github.com/GetStream/ios-issues-tracking/issues/601
🎯 Goal
Embed third-party dependencies
🧪 Testing
☑️ Checklist