Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Test Helpers from Package.swift #2828

Merged
merged 2 commits into from
Oct 9, 2023
Merged

Remove Test Helpers from Package.swift #2828

merged 2 commits into from
Oct 9, 2023

Conversation

testableapple
Copy link
Contributor

@testableapple testableapple commented Oct 5, 2023 •
edited
Loading

🔗 Issue Links

Resolves https://github.com/GetStream/ios-issues-tracking/issues/579
Resolves https://github.com/GetStream/ios-issues-tracking/issues/539

📝 Summary

  • StreamChatTestHelpers is removed from Package.swift
  • StreamChatTestHelpers is renamed to StreamSwiftTestHelpers
  • SnapshotTesting extracted into StreamSwiftTestHelpers
  • SnapshotTesting version bumped to better work on Xcode 15
  • Deployment target bumped to 12

🧪 Testing

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero ⚠️ policy (required)
  • This change should be manually QAed
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (docusaurus, tutorial, CMS)

🎁 Meme

gif

@github-actions
Copy link

github-actions bot commented Oct 5, 2023 •
edited
Loading

1 Warning
⚠️ Big PR

Generated by 🚫 Danger

@testableapple testableapple force-pushed the ci/spm branch 3 times, most recently from d7736ab to aaa3b44 Compare October 5, 2023 10:09
@testableapple testableapple marked this pull request as ready for review October 5, 2023 13:50
@testableapple testableapple requested a review from a team as a code owner October 5, 2023 13:50
@testableapple testableapple added the 🤖 CI/CD Any work related to CI/CD label Oct 5, 2023
@testableapple testableapple mentioned this pull request Oct 9, 2023
Merged
7 tasks
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 16 Code Smells

90.0% 90.0% Coverage
0.0% 0.0% Duplication

nuno-vieira
nuno-vieira approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@nuno-vieira nuno-vieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

@testableapple testableapple merged commit 8427a49 into develop Oct 9, 2023
17 checks passed
@testableapple testableapple deleted the ci/spm branch October 9, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nuno-vieira nuno-vieira nuno-vieira approved these changes

@polqf polqf polqf approved these changes

Assignees
No one assigned
Labels
🤖 CI/CD Any work related to CI/CD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@testableapple @polqf @nuno-vieira