Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using VerticalGrid::can_connect_to; added VerticalGrid::is_identical_to #3194

Merged

Conversation

pchakraborty
Copy link
Contributor

@pchakraborty pchakraborty commented Nov 26, 2024

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)
  • Refactor (no functional changes, no api changes)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

  • FieldSpec::adapt_vertical_grid now uses VerticalGrid::can_connect_to to verify that regridding is possible between src and dst vertical grids
  • FieldSpec::adapter_match_vertical_grid now uses VerticalGrid::is_identical_to instead of the contained same_vertical_grid. This resolves the issue of circular dependency that prevented handling of ModelVerticalGrid in FieldSpec

Related Issue

@pchakraborty pchakraborty self-assigned this Nov 26, 2024
@pchakraborty pchakraborty added 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 📈 MAPL3 MAPL 3 Related Changelog Skip Skips the Changelog Enforcer labels Nov 26, 2024
@pchakraborty pchakraborty changed the title Using VerticalGrid::can_connect_to Using VerticalGrid::can_connect_to; added VerticalGrid::is_identical_to Nov 26, 2024
@pchakraborty pchakraborty added the 🚫 Contingent - DNA Do Not Approve (DNA). These changes are contingent on other PRs label Nov 26, 2024
@pchakraborty pchakraborty marked this pull request as ready for review November 29, 2024 13:54
@pchakraborty pchakraborty requested a review from a team as a code owner November 29, 2024 13:54
@pchakraborty pchakraborty removed the 🚫 Contingent - DNA Do Not Approve (DNA). These changes are contingent on other PRs label Dec 2, 2024
@pchakraborty pchakraborty merged commit 7b5fab0 into release/MAPL-v3 Dec 2, 2024
42 of 43 checks passed
@pchakraborty pchakraborty deleted the feature/pchakrab/vertical-regridding-can-connect branch December 2, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. Changelog Skip Skips the Changelog Enforcer 📈 MAPL3 MAPL 3 Related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants