-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using VerticalGrid::can_connect_to; added VerticalGrid::is_identical_to #3194
Merged
pchakraborty
merged 11 commits into
release/MAPL-v3
from
feature/pchakrab/vertical-regridding-can-connect
Dec 2, 2024
Merged
Using VerticalGrid::can_connect_to; added VerticalGrid::is_identical_to #3194
pchakraborty
merged 11 commits into
release/MAPL-v3
from
feature/pchakrab/vertical-regridding-can-connect
Dec 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…so as not to hardwire them in ComponentSpecParser::parse_geometry_spec
pchakraborty
added
0 Diff
The changes in this pull request have verified to be zero-diff with the target branch.
📈 MAPL3
MAPL 3 Related
Changelog Skip
Skips the Changelog Enforcer
labels
Nov 26, 2024
pchakraborty
changed the title
Using VerticalGrid::can_connect_to
Using VerticalGrid::can_connect_to; added VerticalGrid::is_identical_to
Nov 26, 2024
pchakraborty
added
the
🚫 Contingent - DNA
Do Not Approve (DNA). These changes are contingent on other PRs
label
Nov 26, 2024
tclune
approved these changes
Dec 2, 2024
pchakraborty
removed
the
🚫 Contingent - DNA
Do Not Approve (DNA). These changes are contingent on other PRs
label
Dec 2, 2024
pchakraborty
deleted the
feature/pchakrab/vertical-regridding-can-connect
branch
December 2, 2024 13:42
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
0 Diff
The changes in this pull request have verified to be zero-diff with the target branch.
Changelog Skip
Skips the Changelog Enforcer
📈 MAPL3
MAPL 3 Related
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of change(s)
Checklist
make tests
)Description
FieldSpec::adapt_vertical_grid
now usesVerticalGrid::can_connect_to
to verify that regridding is possible between src and dst vertical gridsFieldSpec::adapter_match_vertical_grid
now usesVerticalGrid::is_identical_to
instead of thecontain
edsame_vertical_grid
. This resolves the issue of circular dependency that prevented handling of ModelVerticalGrid in FieldSpecRelated Issue