Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify short names of ModelVerticalGrid fields in yaml file #3193

Closed

Conversation

pchakraborty
Copy link
Contributor

@pchakraborty pchakraborty commented Nov 25, 2024

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)
  • Refactor (no functional changes, no api changes)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

  • Introduced field_edge/center in the yaml config file, so that a model vertical grid is now specified in the yaml file as follows:
    mapl:
      geometry:
        vertical_grid:
          class: model
          standard_name: air_pressure
          field_edge: PLE
          field_center: PL
          units: hPa
          num_levels: 4
  • Updated Scenarios tests where a model vertical grid is specified
  • Some cleanup of ComponentSpecParser::parse_geometry_spec - vertical grid is parsed in a separate routine now
  • Refactored Test_ModelVerticalGrid.F90
  • Updated overloaded write of ModelVerticalGrid to include standard name and field names for edge and center variables

Related Issue

@pchakraborty pchakraborty requested a review from a team as a code owner November 25, 2024 17:02
@pchakraborty
Copy link
Contributor Author

Resolves #3184

@pchakraborty pchakraborty self-assigned this Nov 25, 2024
@pchakraborty pchakraborty added 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 📈 MAPL3 MAPL 3 Related Changelog Skip Skips the Changelog Enforcer 🛠️ Refactor This is code refactoring labels Nov 25, 2024
@pchakraborty
Copy link
Contributor Author

These edits were included in #3194. Closing this, since #3194 has already been merged.

@pchakraborty pchakraborty deleted the feature/pchakrab/vertical-regridding branch December 2, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. Changelog Skip Skips the Changelog Enforcer 📈 MAPL3 MAPL 3 Related 🛠️ Refactor This is code refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant