Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remaining issues in vertical regridding #3186

Closed
pchakraborty opened this issue Nov 19, 2024 · 6 comments
Closed

Remaining issues in vertical regridding #3186

pchakraborty opened this issue Nov 19, 2024 · 6 comments
Assignees
@pchakraborty

Comments

@pchakraborty
Copy link
Contributor

pchakraborty commented Nov 19, 2024 •
edited
Loading

  1. Specify short name of vertical grid coordinate in yaml file, instead of hardwiring them in parse_geometry_spec #3184
  2. Refactor Test_ModelVerticalGrid.pf
  3. Resolve issue in the case there is a mismatch (edge vs center vertical staggering) in vertical regridding
  4. Resolve gfortran segfault issue with running vertical_regridding_2/3
  5. Have VerticalRegridAction::initialize compute the initial transformation matrix and find a way to trigger a re-compute in case src and dst vccords change.
  6. FieldSpec::adapter_match_vertical_grid::same_vertical_grid - how to handle ModelVerticalGrid? Cannot use ModelVerticalGrid because of circular dependency.
  7. Make use of VerticalGrid::can_connect_to
@pchakraborty pchakraborty self-assigned this Nov 19, 2024
@pchakraborty
Copy link
Contributor Author

3 - addressed in #3190

@pchakraborty
Copy link
Contributor Author

2 - db8cd4d

@pchakraborty
Copy link
Contributor Author

pchakraborty commented Nov 25, 2024 •
edited
Loading

1 and 2 - #3193

@pchakraborty
Copy link
Contributor Author

6 and 7 - #3194

@pchakraborty
Copy link
Contributor Author

4 - #3195

@pchakraborty
Copy link
Contributor Author

Created new issue for 5. Closing this in favor of #3196.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pchakraborty pchakraborty

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pchakraborty