-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
README+Docs: Add virtual environments as recommended usage way #176
README+Docs: Add virtual environments as recommended usage way #176
Conversation
Since you are doing the document, could you add a line about FASM installation? The standard installation will yield a warning. |
When I try to install with
|
Are you executing it inside a venv? I also got this error, but only when using it with the global python installation. |
I am doing a global installation. I will do it the venv way. The document will also need to mention this then. |
For this reason I made this PR :) It is generally no longer recommended to install python packages with pip globally, since it can break Python system packages and can cause problems with shared dependencies. In newer Python versions (>=3.11) it will throw an error, if you try to install any packages globally with pip. |
This issue seems to be caused by an old version of setuptools. I've updated the pyproject.toml, could you please try to install it again globally from this branch? |
If the global install is deprecated, should we only stick to the venv installation? |
I still get the error on global install, even with the We could also change the documentation from recommending a venv to making a venv a prerequiste, since it is clearly a better way to install the package, for the reasons you mentioned @EverythingElseWasAlreadyTaken . |
Maybe you have to update setuptools manually and also update pip to make this work.
The venv instaallation is the only way described in the documentation. |
Should i just add a Note, that this warning is normal? Or is there a way to fix it? |
To make the warning disappear, we will need to install fasm from the source. I think just putting a note is all we need. |
Okay then I will not try to make the global installation work since I won't use it personally. |
ecc03dc
to
84ab353
Compare
Add description how to use FABulous with virtual environments in README and docs, since it is recommended for working with python projects. Introduce $, (venv)$ and FABulous> as commandprompt prefixes. Signed-off-by: Jonas K. <[email protected]>
Set required version of setuptools to 64, since older versions do not support PEP660. Signed-off-by: Jonas K. <[email protected]>
Add a note how to handle the FASM warning about the missing ANTLR package. Signed-off-by: Jonas K. <[email protected]>
84ab353
to
cd778a2
Compare
I've added a note in the docs and rebased to the current 2.0 changes. |
cd778a2
to
e408d08
Compare
Just for completion, @EverythingElseWasAlreadyTaken and I talked again about this and it was indeed the update of pip that made the global installation work. |
3362417
into
FPGA-Research:FABulous2.0-development
Add description how to use FABulous with virtual environments in README and docs, since it is recommended for working with python projects.
Introduce$, (venv)$ and FABulous> as commandprompt prefixes.