SourceView: add parts in GoToMenu #271
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
include parts information
|
This should also add some changes to the Javascript files. Source was OPERA |
feuerbart
pushed a commit
to feuerbart/Edirom-Online
that referenced
this pull request
Dec 5, 2024
…in goto-menu in sourceview this commit updates the handling of parts in goto-menu. i added movementwise and a preference to edirom-prefs.xml Closes Issue Edirom#13 and PR Edirom#271
Merged
|
as i could not push to ftr/PartsInGoToMenu directly, i opened a separate PR (#493) to pulled from my fork. |
|
Yes, I think we can close this in favor of #493 |
peterstadler
added a commit
that referenced
this pull request
Dec 17, 2024
## Description, Context and related Issue * add parts to goto-menu in source view. * add preference to change order from partwise to movementwise Refs #13 Refs #271 ## How Has This Been Tested? <!--- Please describe in detail how you tested your changes. --> <!--- Include details of your testing environment, and the tests you ran. --> run in local Edirom-Online, tested with open-faust sources A2 (without parts) and A3 (with parts). ## Types of changes - New feature (non-breaking change which adds functionality) - Improvement ## Overview - I have updated the inline documentation accordingly. - I have performed a self-review of my code, according to the [style guide](https://github.com/Edirom/Edirom-Online/blob/develop/STYLE-GUIDE.md) - I have read the [CONTRIBUTING](https://github.com/Edirom/Edirom-Online/blob/develop/CONTRIBUTING.md) document.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
include parts information