-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ftr] Go to… menu in parts #13
Comments
if this is still lan open issue, I can assure you that I fixed it in the OPERA-Editions version some time ago. Merging back was not done due to the ExtJS and repo structure mismatch of the OPERA fork and this repo |
There is an edition where we implemented a sub structure for parts in "Go to" menu. But this doesn't seem to be in the core repo. |
I copied the parts from the OPERA-implementation and was able to make it work. tested with open-faust sources A3 (with parts) and A2 (without parts). see: 9617525 |
You’re correct to assume that the |
…in goto-menu in sourceview this commit updates the handling of parts in goto-menu. i added movementwise and a preference to edirom-prefs.xml Closes Issue Edirom#13 and PR Edirom#271
#493 should solve this issue. |
yes, #101 is basically the same issue. |
## Description, Context and related Issue * add parts to goto-menu in source view. * add preference to change order from partwise to movementwise Refs #13 Refs #271 ## How Has This Been Tested? <!--- Please describe in detail how you tested your changes. --> <!--- Include details of your testing environment, and the tests you ran. --> run in local Edirom-Online, tested with open-faust sources A2 (without parts) and A3 (with parts). ## Types of changes - New feature (non-breaking change which adds functionality) - Improvement ## Overview - I have updated the inline documentation accordingly. - I have performed a self-review of my code, according to the [style guide](https://github.com/Edirom/Edirom-Online/blob/develop/STYLE-GUIDE.md) - I have read the [CONTRIBUTING](https://github.com/Edirom/Edirom-Online/blob/develop/CONTRIBUTING.md) document.
While going to the page displaying the beginning of a movement or number in scores is easy, we need to have an extra layer for parts in part books.
The text was updated successfully, but these errors were encountered: