Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ftr] Go to… menu in parts #13

Closed
roewenstrunk opened this issue Jul 3, 2013 · 7 comments · Fixed by #493
Closed

[ftr] Go to… menu in parts #13

roewenstrunk opened this issue Jul 3, 2013 · 7 comments · Fixed by #493
Assignees
Labels
Status: needs review Issues that might be resolved in current develop Type: feature request
Milestone

Comments

@roewenstrunk
Copy link
Member

While going to the page displaying the beginning of a movement or number in scores is easy, we need to have an extra layer for parts in part books.

@ghost ghost assigned roewenstrunk Jul 3, 2013
@bwbohl
Copy link
Member

bwbohl commented Mar 10, 2021

if this is still lan open issue, I can assure you that I fixed it in the OPERA-Editions version some time ago. Merging back was not done due to the ExtJS and repo structure mismatch of the OPERA fork and this repo

bwbohl added a commit that referenced this issue Jan 21, 2022
@bwbohl bwbohl added the Status: needs review Issues that might be resolved in current develop label Feb 9, 2022
@bwbohl bwbohl modified the milestones: OPERA Release, 1.0.0-beta.6 Feb 6, 2024
nikobeer added a commit that referenced this issue Feb 19, 2024
@bwbohl bwbohl linked a pull request Jun 25, 2024 that will close this issue
@bwbohl bwbohl moved this to New in Edirom Development Jun 26, 2024
@krHERO krHERO moved this from New to In Progress in Edirom Development Jul 3, 2024
@roewenstrunk roewenstrunk changed the title Go to… menu in parts [ftr] Go to… menu in parts Jul 8, 2024
@roewenstrunk
Copy link
Member Author

There is an edition where we implemented a sub structure for parts in "Go to" menu. But this doesn't seem to be in the core repo.

@bwbohl bwbohl modified the milestones: 1.0.0-beta.6, 1.1.0 Sep 5, 2024
@feuerbart
Copy link
Contributor

I copied the parts from the OPERA-implementation and was able to make it work. tested with open-faust sources A3 (with parts) and A2 (without parts).
OPERAs code was never finished, i guess. looks like there is an implementation of partwise and movementwise, but the latter was never finished. probably going to rework it the next days.

see: 9617525

@bwbohl
Copy link
Member

bwbohl commented Dec 4, 2024

You’re correct to assume that the movementwise display was never finished. That was because the decision was to use the partwise exclusively in OPERA. But making it work would be great. Maybe there should be a prefs entry for that?

feuerbart pushed a commit to feuerbart/Edirom-Online that referenced this issue Dec 5, 2024
…in goto-menu in sourceview

this commit updates the handling of parts in goto-menu. i added movementwise and a preference to edirom-prefs.xml
Closes Issue Edirom#13 and PR Edirom#271
@feuerbart
Copy link
Contributor

#493 should solve this issue.

@krHERO krHERO modified the milestones: 1.1.0, 1.0.0 Dec 11, 2024
@krHERO
Copy link
Member

krHERO commented Dec 11, 2024

should #493 also close #101

@feuerbart
Copy link
Contributor

yes, #101 is basically the same issue.

@peterstadler peterstadler linked a pull request Dec 12, 2024 that will close this issue
peterstadler added a commit that referenced this issue Dec 17, 2024
## Description, Context and related Issue
* add parts to goto-menu in source view.
* add preference to change order from partwise to movementwise

Refs #13 
Refs #271 

## How Has This Been Tested?
<!--- Please describe in detail how you tested your changes. -->
<!--- Include details of your testing environment, and the tests you
ran. -->
run in local Edirom-Online, tested with open-faust sources A2 (without
parts) and A3 (with parts).

## Types of changes
- New feature (non-breaking change which adds functionality)
- Improvement

## Overview
- I have updated the inline documentation accordingly.
- I have performed a self-review of my code, according to the [style
guide](https://github.com/Edirom/Edirom-Online/blob/develop/STYLE-GUIDE.md)
- I have read the
[CONTRIBUTING](https://github.com/Edirom/Edirom-Online/blob/develop/CONTRIBUTING.md)
document.
@github-project-automation github-project-automation bot moved this from In Progress to Done in Edirom Development Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: needs review Issues that might be resolved in current develop Type: feature request
Projects
Status: Done
4 participants