Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only open referenced parts with openAll from annotationView #273

Open
bwbohl opened this issue Jun 23, 2022 · 12 comments
Open

only open referenced parts with openAll from annotationView #273

bwbohl opened this issue Jun 23, 2022 · 12 comments
Assignees
Milestone

Comments

@bwbohl
Copy link
Member

bwbohl commented Jun 23, 2022

No description provided.

@bwbohl bwbohl added this to the 1.0.0-beta.4 milestone Jun 23, 2022
@riedde riedde modified the milestones: 1.0.0-beta.4, 1.0.0-beta.5 Jun 25, 2022
@bwbohl
Copy link
Member Author

bwbohl commented Jul 27, 2022

@nikobeer could you please find some edition example that already supports this feature for code comparison?

@bwbohl
Copy link
Member Author

bwbohl commented Oct 5, 2022

might be connected to #271

@nikobeer
Copy link
Member

nikobeer commented Oct 5, 2022

Will have to look in the RWA- and/or OPERA-Edirom. November +…

@riedde riedde self-assigned this Oct 5, 2022
@nikobeer
Copy link
Member

nikobeer commented Nov 23, 2022

Ok, found it in a working state with @bwbohl: OPERA vol. 4, all critical remarks that reference source WO. "OpenAll" will trigger a source window for each participant. When this participant is a measure in a part it will first trigger the "Parts Selection" and then navigate to the measure(s) in question.

We also found some commits that should be helpful. More (re)search needed the next days. Maybe start here: OPERA-Editions@d390fc5

@riedde
Copy link
Contributor

riedde commented Dec 10, 2022

Worked on this today. Even if I don't have a solution, I found out that one problem could be the grouping of measures that combines all measures (even if they are in different parts) into one setting (one source window). When I disable the grouping for measures in parts the right number of source windows appears, but no measures are shown inside them. I tried to fix this at getAnnotationOpenAllURI.xql and also at getParts.xql (idea: define a parameter for select/unselect parts). Both wasn't helpful in the end.

@nikobeer
Copy link
Member

Discussed this with @riedde reviewing OPERA's solution.

Short: Problem remains with sources with parts, because it only works, when there are no multi measure rest measures involved or better: it could work when every logical measure would be present (by an ID) in every part of a/the source in question. As soon as we lose logical measures because of a multi measure rest, we could get lost in the source.

Long Version:

Edirom addresses measures in sources with parts either by:

  1. a virtual measureID build from the parent mdivID + the number label of the measure in question (measure_parentMdivID_measureNo) + sometimes an optional parameter naming the parts that should be take in to account for building and displaying a reduced virtual score ("we came from an edirom concordance and tried configure and to display the source in its source window")
  2. a single measureID from whose n- or label-attribute a measure number is retrieved while its part is evaluated by its parent part element ("we came from an edirom annotation participant and tried to display the participant in its own source window").

The problematic way is "2.", because it uses "1." to configure the source window:

  1. measureID is retrieved from annot plist
  2. measure is searched in source by id
  3. measure part is evaluated (measure's parent part)
  4. measure's parent mdivID is evaluated
  5. measure number is read either from measure/@n or measure/@Label
  6. virtual measureID for part sources is build adding the part parameter
  7. virtual measureID is send to configure the source window

So far so good…

Now, when measure is within a range of a multi measure rest and we only have one measureID (which in this case represents multiple logical measures, ex. "35–40") we get lost. We have no chance to determine which actual measure number we should use to build step "5." to "7.".

Stop here! Think about a solution…

@riedde
Copy link
Contributor

riedde commented Jan 13, 2023

Something that came on my mind: when we have a multiMeasureRest with a count of 4 then we have one measure that represents 4 measures. For addressing the measure, e.g., in parts material we need the logical structure without loosing the information of the visual realization of the "measure" in the manifestation. What if just using measures and group them as an regularization?

<reg type="multiRest">
   <measure n="1"/>
   <measure n="2"/>
   <measure n="3"/>
   <measure n="4"/>
</reg>

See also the definition of <reg>: https://music-encoding.org/guidelines/dev/elements/reg.html

@riedde
Copy link
Contributor

riedde commented Feb 8, 2023

Ideas from todays meeting: <choice> with <abbr>/<expan> or <orig>/<reg>

@bwbohl
Copy link
Member Author

bwbohl commented Feb 8, 2023

<parts>
    <part>
        <section>
            <choice>
                <abbr>
                    <measure>
                        <staff>
                            <layer>
                                <multiRest />
                            </layer>
                        </staff>
                    </measure>
                </abbr>
                <expan>
                    <measure>
                        <staff>
                            <layer>
                                <mRest />
                            </layer>
                        </staff>
                    </measure>
                    <measure>
                        <staff>
                            <layer>
                                <mRest />
                            </layer>
                        </staff>
                    </measure>
                    <measure>
                        <staff>
                            <layer>
                                <mRest />
                            </layer>
                        </staff>
                    </measure>
                </expan>
            </choice>
        </section>
    </part>
</parts>

@bwbohl
Copy link
Member Author

bwbohl commented Jun 25, 2024

This might actually be connected to #271

@bwbohl bwbohl moved this to New in Edirom Development Jun 26, 2024
@bwbohl bwbohl modified the milestones: 1.0.0-beta.6, 1.0.0 Sep 5, 2024
@bwbohl
Copy link
Member Author

bwbohl commented Oct 9, 2024

@riedde & @nikobeer do you see a chance of getting a draft pull request done until November?

@riedde
Copy link
Contributor

riedde commented Oct 12, 2024

@bwbohl I am not sure. Maybe not by me.

@bwbohl bwbohl moved this from New to Backlog in Edirom Development Nov 7, 2024
@bwbohl bwbohl modified the milestones: 1.0.0, 1.1.0 Dec 4, 2024
@krHERO krHERO removed this from the 1.1.0 milestone Dec 11, 2024
@krHERO krHERO added this to the 1.2.0 milestone Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

5 participants