Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing edge #8189

Closed
wants to merge 14 commits into from
Closed

testing edge #8189

wants to merge 14 commits into from

Conversation

Bayheck
Copy link
Collaborator

@Bayheck Bayheck commented May 12, 2024

Purpose

Describe the problem you want to address or the feature you want to implement.

Approach

Describe how your changes address the issue or implement the desired functionality in as much detail as possible.

References

Provide a link to the existing issue(s), if any.

Pre-Merge TODO

  • Write tests for your proposed changes
  • Make sure that existing tests do not fail

@need-response-app need-response-app bot added the STATE: Need response An issue that requires a response or attention from the team. label May 12, 2024
@Bayheck Bayheck removed the STATE: Need response An issue that requires a response or attention from the team. label May 12, 2024
@Bayheck Bayheck mentioned this pull request May 20, 2024
2 tasks
@Bayheck Bayheck marked this pull request as ready for review May 20, 2024 06:47
@Bayheck Bayheck closed this May 20, 2024
Aleksey28 pushed a commit that referenced this pull request Jun 3, 2024
<!--
Thank you for your contribution.

Before making a PR, please read our contributing guidelines at

https://github.com/DevExpress/testcafe/blob/master/CONTRIBUTING.md#code-contribution

We recommend creating a *draft* PR, so that you can mark it as 'ready
for review' when you are done.
-->

## Purpose
Testcafe did not click properly on multiline elements.

## Approach
In testcafe-hammerhead replaced getBoundingClientRect with
getClientRects.

Fix Edge workflow tests
#8189

## References
#8179
#8148

Hammerhead PR:
DevExpress/testcafe-hammerhead#3004


## Pre-Merge TODO
- [x] Write tests for your proposed changes
- [ ] Make sure that existing tests do not fail

---------

Co-authored-by: Bayheck <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant