Click on multiline elements (#8183)

## Purpose Testcafe did not click properly on multiline elements. ## Approach In testcafe-hammerhead replaced getBoundingClientRect with getClientRects. Fix Edge workflow tests #8189 ## References #8179 #8148 Hammerhead PR: DevExpress/testcafe-hammerhead#3004 ## Pre-Merge TODO - [x] Write tests for your proposed changes - [ ] Make sure that existing tests do not fail --------- Co-authored-by: Bayheck <[email protected]>
DevExpress · Jun 3, 2024 · 430918d · 430918d
1 parent 1b17abd
commit 430918d
Show file tree

Hide file tree

Showing 9 changed files with 60 additions and 14 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -142,7 +142,7 @@
     "source-map-support": "^0.5.16",
     "strip-bom": "^2.0.0",
     "testcafe-browser-tools": "2.0.26",
-    "testcafe-hammerhead": "31.7.1",
+    "testcafe-hammerhead": "31.7.2",
     "testcafe-legacy-api": "5.1.8",
     "testcafe-reporter-json": "^2.1.0",
     "testcafe-reporter-list": "^2.2.0",

diff --git a/test/functional/fixtures/browser-provider/job-reporting/test.js b/test/functional/fixtures/browser-provider/job-reporting/test.js
@@ -13,6 +13,7 @@ if (config.useLocalBrowsers) {
         const BROWSER_OPENING_DELAY = 4000;
 
         let mockProvider = null;
+        const needSkip   = config.hasBrowser('edge');
 
         const mockProviderPlugin = Object.assign({}, chromeBrowserProvider, {
             state:     {},
@@ -110,7 +111,7 @@ if (config.useLocalBrowsers) {
                 });
         });
 
-        it('Should report job error to the providers', () => {
+        (needSkip ? it.skip : it)('Should report job error to the providers', () => {
             return run(['chrome --failed-1', 'chrome --id-2'], './testcafe-fixtures/long-test.js')
                 .then(() => {
                     throw new Error('Promise rejection expected');

diff --git a/test/functional/fixtures/regression/gh-2011/test.js b/test/functional/fixtures/regression/gh-2011/test.js
@@ -1,11 +1,13 @@
 const path               = require('path');
 const createTestCafe     = require('../../../../../lib');
+const config             = require('../../../config');
 const { createReporter } = require('../../../utils/reporter');
 const { expect }         = require('chai');
 
-let testCafe = null;
-let runner   = null;
-let errors   = null;
+let testCafe   = null;
+let runner     = null;
+let errors     = null;
+const needSkip = config.hasBrowser('edge');
 
 const reporter = createReporter({
     reportTestDone (_, testRunInfo) {
@@ -35,7 +37,7 @@ const run = (pathToTest, concurrency) => {
         });
 };
 
-describe('[Regression](GH-2011)', function () {
+(needSkip ? describe.skip : describe)('[Regression](GH-2011)', function () {
 
     it('Should execute all fixture\'s test with disableConcurrency in one browser', function () {
         return run('./testcafe-fixtures/concurrency-mode-with-disable-concurrency-fixture-test.js', 3)

diff --git a/test/functional/fixtures/regression/gh-2568/test.js b/test/functional/fixtures/regression/gh-2568/test.js
@@ -1,7 +1,7 @@
 const expect = require('chai').expect;
 
 function removeWhitespaces (str) {
-    return str.replace(/\s+|\n/g, ' ').trim();
+    return str?.replace(/\s+|\n/g, ' ').trim() ?? '';
 }
 
 function assertSelectorCallstack (actual, expected) {

diff --git a/test/functional/fixtures/regression/gh-8179/pages/index.html b/test/functional/fixtures/regression/gh-8179/pages/index.html
@@ -0,0 +1,18 @@
+<!DOCTYPE html>
+<html>
+    <head>
+        <meta http-equiv="Content-Type" content="text/html; charset=UTF-8" />
+        <title>gh-8179</title>
+        <style>
+            .main {
+                width: 300px;
+            }
+        </style>
+    </head>
+    <body>
+        <div class="main">
+            This here link will take you to the
+            <a href="success.html">success page</a>.
+        </div>
+    </body>
+</html>
diff --git a/test/functional/fixtures/regression/gh-8179/pages/success.html b/test/functional/fixtures/regression/gh-8179/pages/success.html
@@ -0,0 +1,10 @@
+<!DOCTYPE html>
+<html lang="en">
+    <head>
+        <meta charset="UTF-8" />
+        <title>Title</title>
+    </head>
+    <body>
+        <h1>success</h1>
+    </body>
+</html>
diff --git a/test/functional/fixtures/regression/gh-8179/test.js b/test/functional/fixtures/regression/gh-8179/test.js
@@ -0,0 +1,5 @@
+describe('[Regression](GH-8179)', function () {
+    it('Should click on a two-word link split over two lines', function () {
+        return runTests('testcafe-fixtures/index.js');
+    });
+});
diff --git a/test/functional/fixtures/regression/gh-8179/testcafe-fixtures/index.js b/test/functional/fixtures/regression/gh-8179/testcafe-fixtures/index.js
@@ -0,0 +1,10 @@
+import { Selector } from 'testcafe';
+
+fixture`GH-8179 - Should click on a two-word link split over two lines`
+    .page`http://localhost:3000/fixtures/regression/gh-8179/pages/index.html`;
+
+test('Click on a split link', async t => {
+    await t
+        .click('.main a')
+        .expect(Selector('h1').innerText).eql('success');
+});