Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Click on multiline elements #8183

Merged
merged 10 commits into from
Jun 3, 2024
Merged

Conversation

Bayheck
Copy link
Collaborator

@Bayheck Bayheck commented May 4, 2024

Purpose

Testcafe did not click properly on multiline elements.

Approach

In testcafe-hammerhead replaced getBoundingClientRect with getClientRects.

Fix Edge workflow tests
#8189

References

#8179
#8148

Hammerhead PR:
DevExpress/testcafe-hammerhead#3004

Pre-Merge TODO

  • Write tests for your proposed changes
  • Make sure that existing tests do not fail

@need-response-app need-response-app bot added the STATE: Need response An issue that requires a response or attention from the team. label May 4, 2024
@Bayheck Bayheck removed the STATE: Need response An issue that requires a response or attention from the team. label May 4, 2024
@Bayheck Bayheck changed the title testing Click on elements with multiple rects May 10, 2024
@Bayheck Bayheck changed the title Click on elements with multiple rects Click on multiline elements May 10, 2024
@Bayheck Bayheck marked this pull request as ready for review May 10, 2024 09:39
@Bayheck Bayheck requested a review from aleks-pro as a code owner May 10, 2024 09:39
package.json Outdated Show resolved Hide resolved
@Aleksey28 Aleksey28 merged commit 430918d into DevExpress:master Jun 3, 2024
21 checks passed
Copy link

github-actions bot commented Jun 4, 2024

Release v3.6.1-rc.1 addresses this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants