Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Click on multiline elements #8183

Merged
merged 10 commits into from
Jun 3, 2024
+60 −14
Merged

Click on multiline elements #8183

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
3813c10
testing
May 4, 2024
ddab883
update createMouseEventOptions method
May 6, 2024
15c7572
refactor and fixing tests
May 6, 2024
5d8f449
testing with update hammerhead build
May 7, 2024
fcdc270
updated hammerhead
May 8, 2024
43e737b
update: tests added
May 10, 2024
3dbfaaf
tests fixed
May 20, 2024
2e8c51e
fix pr comments
May 21, 2024
e8257fb
update testcafe-hammerhead
May 29, 2024
9575d76
update testcafe-hammerhead
May 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@
"source-map-support": "^0.5.16",
"strip-bom": "^2.0.0",
"testcafe-browser-tools": "2.0.26",
"testcafe-hammerhead": "31.7.1",
"testcafe-hammerhead": "^31.7.2",
PavelMor25 marked this conversation as resolved.
Show resolved Hide resolved
"testcafe-legacy-api": "5.1.8",
"testcafe-reporter-json": "^2.1.0",
"testcafe-reporter-list": "^2.2.0",
Expand Down
3 changes: 2 additions & 1 deletion test/functional/fixtures/browser-provider/job-reporting/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ if (config.useLocalBrowsers) {
const BROWSER_OPENING_DELAY = 4000;

let mockProvider = null;
const needSkip = config.hasBrowser('edge');

const mockProviderPlugin = Object.assign({}, chromeBrowserProvider, {
state: {},
Expand Down Expand Up @@ -110,7 +111,7 @@ if (config.useLocalBrowsers) {
});
});

it('Should report job error to the providers', () => {
(needSkip ? it.skip : it)('Should report job error to the providers', () => {
return run(['chrome --failed-1', 'chrome --id-2'], './testcafe-fixtures/long-test.js')
.then(() => {
throw new Error('Promise rejection expected');
Expand Down
10 changes: 6 additions & 4 deletions test/functional/fixtures/regression/gh-2011/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,13 @@
const path = require('path');
const createTestCafe = require('../../../../../lib');
const config = require('../../../config');
const { createReporter } = require('../../../utils/reporter');
const { expect } = require('chai');

let testCafe = null;
let runner = null;
let errors = null;
let testCafe = null;
let runner = null;
let errors = null;
const needSkip = config.hasBrowser('edge');

const reporter = createReporter({
reportTestDone (_, testRunInfo) {
Expand Down Expand Up @@ -35,7 +37,7 @@ const run = (pathToTest, concurrency) => {
});
};

describe('[Regression](GH-2011)', function () {
(needSkip ? describe.skip : describe)('[Regression](GH-2011)', function () {

it('Should execute all fixture\'s test with disableConcurrency in one browser', function () {
return run('./testcafe-fixtures/concurrency-mode-with-disable-concurrency-fixture-test.js', 3)
Expand Down
2 changes: 1 addition & 1 deletion test/functional/fixtures/regression/gh-2568/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
const expect = require('chai').expect;

function removeWhitespaces (str) {
return str.replace(/\s+|\n/g, ' ').trim();
return str?.replace(/\s+|\n/g, ' ').trim() ?? '';
}

function assertSelectorCallstack (actual, expected) {
Expand Down
18 changes: 18 additions & 0 deletions test/functional/fixtures/regression/gh-8179/pages/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
<!DOCTYPE html>
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8" />
<title>gh-8179</title>
<style>
.main {
width: 300px;
}
</style>
</head>
<body>
<div class="main">
This here link will take you to the
<a href="success.html">success page</a>.
</div>
</body>
</html>
10 changes: 10 additions & 0 deletions test/functional/fixtures/regression/gh-8179/pages/success.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8" />
<title>Title</title>
</head>
<body>
<h1>success</h1>
</body>
</html>
5 changes: 5 additions & 0 deletions test/functional/fixtures/regression/gh-8179/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
describe('[Regression](GH-8179)', function () {
it('Should click on a two-word link split over two lines', function () {
return runTests('testcafe-fixtures/index.js');
});
});
10 changes: 10 additions & 0 deletions test/functional/fixtures/regression/gh-8179/testcafe-fixtures/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
import { Selector } from 'testcafe';

fixture`GH-8179 - Should click on a two-word link split over two lines`
.page`http://localhost:3000/fixtures/regression/gh-8179/pages/index.html`;

test('Click on a split link', async t => {
await t
.click('.main a')
.expect(Selector('h1').innerText).eql('success');
});
Loading