Make sure state starts at close to now tick #1078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 29, 2024
This was referenced Oct 29, 2024
Merged
Merged
Merged
This was referenced Oct 29, 2024
blt
force-pushed
the
blt/uniformly_advance_time_in_logrotate_fs
branch
from
33fb7b1
to
a9cf992
Compare
blt
force-pushed
the
blt/make_sure_state_starts_at_close_to_now_tick
branch
from
bbd5932
to
8386be5
Compare
blt
force-pushed
the
blt/uniformly_advance_time_in_logrotate_fs
branch
from
a9cf992
to
27d221b
Compare
blt
force-pushed
the
blt/make_sure_state_starts_at_close_to_now_tick
branch
from
8386be5
to
56c204c
Compare
This was referenced Oct 29, 2024
blt
force-pushed
the
blt/uniformly_advance_time_in_logrotate_fs
branch
from
27d221b
to
4ebe0f8
Compare
blt
force-pushed
the
blt/make_sure_state_starts_at_close_to_now_tick
branch
from
56c204c
to
fb27b08
Compare
Merged
blt
force-pushed
the
blt/uniformly_advance_time_in_logrotate_fs
branch
2 times, most recently
from
99ccde9
to
dad6f82
Compare
blt
force-pushed
the
blt/make_sure_state_starts_at_close_to_now_tick
branch
from
fb27b08
to
811f71c
Compare
blt
force-pushed
the
blt/uniformly_advance_time_in_logrotate_fs
branch
from
dad6f82
to
2a279ce
Compare
blt
force-pushed
the
blt/make_sure_state_starts_at_close_to_now_tick
branch
from
811f71c
to
4b52809
Compare
goxberry
approved these changes
Oct 31, 2024
blt
changed the base branch from
blt/uniformly_advance_time_in_logrotate_fs
to
graphite-base/1078
blt
force-pushed
the
graphite-base/1078
branch
from
2a279ce
to
89b7f7a
Compare
blt
force-pushed
the
blt/make_sure_state_starts_at_close_to_now_tick
branch
from
4b52809
to
4fb2c61
Compare
This commit ensures that at startup the state does not start at an arbitrary tick but at one synchronized with the logrotate_fs. In practice this comes to the same thing -- today -- but it's an easy bug to trip on in the future. Signed-off-by: Brian L. Troutwine <[email protected]>
blt
force-pushed
the
blt/make_sure_state_starts_at_close_to_now_tick
branch
from
4fb2c61
to
82c3b70
Compare
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This commit ensures that at startup the state does not start at an
arbitrary tick but at one synchronized with the logrotate_fs. In
practice this comes to the same thing -- today -- but it's an easy
bug to trip on in the future.