Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add component pieces for rotation #1055

Merged
merged 2 commits into from
Oct 28, 2024
Merged

Conversation

blt
Copy link
Collaborator

@blt blt commented Oct 22, 2024

What does this PR do?

This commit places the last few bits needed for file rotation. At this point I intend to add a list of static names to index into and then after that, expand State::advance_time to perform rotations.

@blt blt added the no-changelog label Oct 22, 2024 — with Graphite App
@blt blt marked this pull request as ready for review October 22, 2024 22:08
@blt blt requested a review from a team as a code owner October 22, 2024 22:08
@blt blt force-pushed the blt/adjust_time_advancement_to_be_done_by_state branch from 3eca4b6 to 33ef3c3 Compare October 22, 2024 23:51
@blt blt force-pushed the blt/add_component_pieces_for_rotation branch from e59b545 to 246ecfa Compare October 22, 2024 23:51
This was referenced Oct 22, 2024
@blt blt force-pushed the blt/adjust_time_advancement_to_be_done_by_state branch from 33ef3c3 to 1c4ee6a Compare October 23, 2024 23:54
@blt blt force-pushed the blt/add_component_pieces_for_rotation branch from 246ecfa to 5e03bcd Compare October 23, 2024 23:55
@blt blt force-pushed the blt/adjust_time_advancement_to_be_done_by_state branch from 1c4ee6a to 39ae8e6 Compare October 23, 2024 23:58
@blt blt force-pushed the blt/add_component_pieces_for_rotation branch from 5e03bcd to 03504ac Compare October 23, 2024 23:58
@blt blt force-pushed the blt/adjust_time_advancement_to_be_done_by_state branch from 39ae8e6 to 7a18465 Compare October 24, 2024 00:02
@blt blt force-pushed the blt/add_component_pieces_for_rotation branch from 03504ac to f320dbe Compare October 24, 2024 00:02
@blt blt force-pushed the blt/adjust_time_advancement_to_be_done_by_state branch from 7a18465 to f48b2c9 Compare October 24, 2024 00:10
@blt blt force-pushed the blt/add_component_pieces_for_rotation branch from f320dbe to dc29a49 Compare October 24, 2024 00:10
@blt blt force-pushed the blt/adjust_time_advancement_to_be_done_by_state branch from f48b2c9 to cfe6cf9 Compare October 24, 2024 00:20
@blt blt force-pushed the blt/add_component_pieces_for_rotation branch from dc29a49 to 05f5b2f Compare October 24, 2024 00:20
@blt blt force-pushed the blt/adjust_time_advancement_to_be_done_by_state branch from cfe6cf9 to d80ba3e Compare October 24, 2024 00:26
@blt blt force-pushed the blt/add_component_pieces_for_rotation branch from 05f5b2f to 6632e65 Compare October 24, 2024 00:26
This was referenced Oct 25, 2024
@blt blt force-pushed the blt/adjust_time_advancement_to_be_done_by_state branch from b72b315 to fa59a04 Compare October 28, 2024 17:17
@blt blt force-pushed the blt/add_component_pieces_for_rotation branch from 77e7d48 to 4e0bcc7 Compare October 28, 2024 17:17
@blt blt force-pushed the blt/adjust_time_advancement_to_be_done_by_state branch from fa59a04 to 973c1c4 Compare October 28, 2024 17:46
@blt blt force-pushed the blt/add_component_pieces_for_rotation branch from 4e0bcc7 to cd29866 Compare October 28, 2024 17:46
@blt blt force-pushed the blt/adjust_time_advancement_to_be_done_by_state branch from 973c1c4 to a4734f1 Compare October 28, 2024 18:24
@blt blt force-pushed the blt/add_component_pieces_for_rotation branch from cd29866 to 4c61a42 Compare October 28, 2024 18:24
@blt blt force-pushed the blt/adjust_time_advancement_to_be_done_by_state branch 2 times, most recently from ca57ac5 to 11fcc8c Compare October 28, 2024 19:01
@blt blt force-pushed the blt/add_component_pieces_for_rotation branch from 4c61a42 to 1a511ea Compare October 28, 2024 19:01
@blt blt changed the base branch from blt/adjust_time_advancement_to_be_done_by_state to graphite-base/1055 October 28, 2024 19:35
This commit places the last few bits needed for file rotation. At this point I intend
to add a list of static names to index into and then after that, expand State::advance_time
to perform rotations.

Signed-off-by: Brian L. Troutwine <[email protected]>
@blt blt force-pushed the blt/add_component_pieces_for_rotation branch from 1a511ea to 13250d9 Compare October 28, 2024 19:35
@blt blt changed the base branch from graphite-base/1055 to main October 28, 2024 19:35
Signed-off-by: Brian L. Troutwine <[email protected]>
@blt blt force-pushed the blt/add_component_pieces_for_rotation branch from 13250d9 to 05a1656 Compare October 28, 2024 19:35
@blt blt merged commit dfbb553 into main Oct 28, 2024
16 checks passed
Copy link
Collaborator Author

blt commented Oct 28, 2024

Merge activity

  • Oct 28, 4:11 PM EDT: A user merged this pull request with Graphite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants